yieldoneBidAdapter: fix encode referrer twice #4880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, but adding @kusapan and @koji-eguchi to confirm. |
bretg
approved these changes
Feb 21, 2020
|
No answer from the originators, going ahead with the merge. |
monofonik
pushed a commit
to playground-xyz/Prebid.js
that referenced
this pull request
Feb 25, 2020
|
@bretg confirmed. Thank you for the merge. |
rjvelicaria
pushed a commit
to openx/Prebid.js
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Bugfix for yieldoneAdapter encoded
rparameter twice.yieldoneAdapter makes unexpected request like
{ "r": "https%253A%252F%252F...", ... }.buildRequests makes encode
rparameter. But newBidder.processRequest encode query parameters too(here). Sorparameter in bid request is encoded excessively.yieldoneAdapter for v2 has same issue.