-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Adnuntius Bid Adapter #4896
Conversation
Hi, do I need to change this line?
in order to pass the CI test? I ran the test locally and it passed. |
Hi @mikael-lundin , yes, you're right. Can you change L27 and L53, |
This pull request introduces 1 alert when merging 0f9d9bb into 703b898 - view on LGTM.com new alerts:
|
Hey @mikael-lundin, I don't see that |
docs PR prebid/prebid.github.io#1821 |
Hi, are there any outstanding issue with this? |
@mikael-lundin - there are two comments above that don't appear to have fixes yet. |
* Added Adnuntius Bid Adapter * Changes to Adnuntius bidder according to comments. * Fixed non used variable warning. * Fixed outstanding issues * Fixed issue in test and bidder. * Fixed all the "for ... of" Issues.
* Added Adnuntius Bid Adapter * Changes to Adnuntius bidder according to comments. * Fixed non used variable warning. * Fixed outstanding issues * Fixed issue in test and bidder. * Fixed all the "for ... of" Issues.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information