Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Adnuntius Bid Adapter #4896

Merged
merged 6 commits into from
Mar 24, 2020
Merged

Added Adnuntius Bid Adapter #4896

merged 6 commits into from
Mar 24, 2020

Conversation

mikael-lundin
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@mikael-lundin
Copy link
Contributor Author

Hi, do I need to change this line?

for (const bid of validBidRequests) {

in order to pass the CI test? I ran the test locally and it passed.

@aleksatr
Copy link
Contributor

Hi, do I need to change this line?

for (const bid of validBidRequests) {

in order to pass the CI test? I ran the test locally and it passed.

Hi @mikael-lundin , yes, you're right. Can you change L27 and L53, for ( ... of ... ) is not supported by IE11.

modules/adnuntiusBidAdapter.js Outdated Show resolved Hide resolved
modules/adnuntiusBidAdapter.js Outdated Show resolved Hide resolved
modules/adnuntiusBidAdapter.js Outdated Show resolved Hide resolved
modules/adnuntiusBidAdapter.js Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Mar 13, 2020

This pull request introduces 1 alert when merging 0f9d9bb into 703b898 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@aleksatr
Copy link
Contributor

Hi, do I need to change this line?
for (const bid of validBidRequests) {
in order to pass the CI test? I ran the test locally and it passed.

Hi @mikael-lundin , yes, you're right. Can you change L27 and L53, for ( ... of ... ) is not supported by IE11.

Hey @mikael-lundin, I don't see that for (... of ...) constructs were addressed?

@bretg
Copy link
Collaborator

bretg commented Mar 16, 2020

docs PR prebid/prebid.github.io#1821

@mikael-lundin
Copy link
Contributor Author

Hi, are there any outstanding issue with this?

@bretg
Copy link
Collaborator

bretg commented Mar 23, 2020

@mikael-lundin - there are two comments above that don't appear to have fixes yet.

@aleksatr aleksatr merged commit da6bb01 into prebid:master Mar 24, 2020
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* Added Adnuntius Bid Adapter

* Changes to Adnuntius bidder according to comments.

* Fixed non used variable warning.

* Fixed outstanding issues

* Fixed issue in test and bidder.

* Fixed all the "for ... of" Issues.
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
* Added Adnuntius Bid Adapter

* Changes to Adnuntius bidder according to comments.

* Fixed non used variable warning.

* Fixed outstanding issues

* Fixed issue in test and bidder.

* Fixed all the "for ... of" Issues.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants