-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enforcement for deviceAccess #4913
Merged
bretg
merged 82 commits into
prebid:master
from
rubicon-project:add-enforcement-device-access
Mar 17, 2020
Merged
Changes from all commits
Commits
Show all changes
82 commits
Select commit
Hold shift + click to select a range
8d635ff
Add microadBidAdapter
3055b90
Remove unnecessary encodeURIComponent from microadBidAdapter
67fb91b
Submit Advangelists Prebid Adapter
3ebb916
Submit Advangelists Prebid Adapter 1.1
4f5c451
Correct procudtion endpoint for prebid
2dc6d1d
Merge branch 'microad-bid-adapter' of git://github.com/strong-zero/Pr…
fa3e081
Merge remote-tracking branch 'origin/master' into master-rubicon-clean
600a46e
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
7f578b3
Merge branch 'master' of https://github.com/prebid/Prebid.js
176a312
Merge branch 'master' of https://github.com/prebid/Prebid.js
9abf89c
Merge branch 'master' of https://github.com/prebid/Prebid.js
6ce04ab
Merge remote-tracking branch 'upstream/master'
415e2f6
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
61fb82c
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
3cc4c67
analytics update with wrapper name
cd81e02
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
e2b4e04
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
53b5970
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
5c00ed5
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
28848ad
reverted error merge
ab635ee
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
93308f5
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
1cfd52d
Merge branch 'master' of https://github.com/prebid/Prebid.js
d619807
Merge branch 'master' of https://github.com/prebid/Prebid.js
9893f0f
Merge branch 'master' of https://github.com/prebid/Prebid.js
986a251
Merge remote-tracking branch 'upstream/master'
2cae7c0
Merge branch 'master' of https://github.com/prebid/Prebid.js into ori…
d7fd252
Merge branch 'master' of https://github.com/prebid/Prebid.js
c7c01ba
Merge branch 'master' of https://github.com/prebid/Prebid.js
24a28aa
Merge branch 'master' of https://github.com/prebid/Prebid.js
7a1a4ec
Merge branch 'master' of https://github.com/rubicon-project/Prebid.js
4173d16
Merge branch 'master' of https://github.com/prebid/Prebid.js
ca13952
update changed default value of netRevenue to true
0b6cd48
Merge branch 'master' of https://github.com/prebid/Prebid.js
5f0110d
Merge branch 'master' of https://github.com/prebid/Prebid.js
f930a34
Merge remote-tracking branch 'upstream/master'
9bff282
Merge branch 'master' of https://github.com/prebid/Prebid.js
712ec9e
Merge branch 'master' of https://github.com/prebid/Prebid.js
f192f65
Merge branch 'master' of https://github.com/prebid/Prebid.js
006f53c
Merge branch 'master' of https://github.com/prebid/Prebid.js
0341150
Merge branch 'master' of https://github.com/prebid/Prebid.js
fa59897
Merge branch 'master' of https://github.com/prebid/Prebid.js
dcff2cf
Merge branch 'master' of https://github.com/prebid/Prebid.js
0222ce2
Merge branch 'master' of https://github.com/prebid/Prebid.js
227beca
Merge branch 'master' of https://github.com/prebid/Prebid.js
dc3ee49
Merge branch 'master' of https://github.com/rubicon-project/Prebid.js
9a5a08d
Merge branch 'master' of https://github.com/prebid/Prebid.js
35ea5d4
Merge branch 'master' of https://github.com/prebid/Prebid.js
f89b71c
Merge branch 'master' of https://github.com/prebid/Prebid.js
4e1679b
Re-add rubicon analytics without deprecated getTopWindowUrl util
fd80acd
Cache referrer on auction_init instead of bid_requested
2ab26a3
Merge pull request #51 from rubicon-project/rubicon-analytics-3.0
msm0504 7de7ca6
Merge branch 'master' of https://github.com/rubicon-project/Prebid.js
5f1fe06
Merge branch 'master' of https://github.com/prebid/Prebid.js
60b5ad8
Merge branch 'master' of https://github.com/prebid/Prebid.js
5f44edd
Merge branch 'master' of https://github.com/rubicon-project/Prebid.js
4809354
Merge branch 'master' of https://github.com/prebid/Prebid.js
8d8bdff
Merge branch 'master' of https://github.com/prebid/Prebid.js
a1a2318
Merge branch 'master' of https://github.com/prebid/Prebid.js
ac2ac12
Merge branch 'master' of https://github.com/prebid/Prebid.js
dac2484
add config for deviceAccess enforcement in utils getCookie setCookie …
fd307e5
add tests, and updates to names/comments
e5880f2
add deviceAccess enforcement to util method cookiesAreEnabled
4240883
update to adspendBidAdapter for device access enforcement
c18c61d
update to pubCommonId for device access enforcement
8f76851
update widespaceBidAdapter for device access enforcement. updated uti…
473e107
update to digiTrustIdSystem for device access enforcement
b049ea2
updated utils.setCookie signature, adding a 'domain' argument. update…
c467a07
updated utils to group similar storage methods
78664ba
updated kargoBidAdapter for add-enforcement-device-access
0dbadf8
update to minimize changes in adapters using browser storage
fd04c8d
Merge branch 'master' of https://github.com/prebid/Prebid.js into add…
fa07c42
updated modules with localStorage or cookie methods to use utils
5cae477
updated invibesBidAdapter use of storage methods to use utils
9336ea4
fix for wrong obj reference for date string
af229e7
revert accidental change to package.json
6d064cf
fix linting error, trailing comma. removed unnecessary cookie get set…
c3c5b09
reverted change to removed extra methods since it breaks unit test
891ecbd
fix for pubcommonidsystem id generation
f281ee2
update jsdoc param 'domain'
b0827c3
Update adagioBidAdapter.js
bretg 025886c
Removing encoding in DT encId
bretg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -342,15 +342,15 @@ function getLanguage() { | |
|
||
function getLocalStorageSafely(key) { | ||
try { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hello @bretg! |
||
return localStorage.getItem(key); | ||
return utils.getDataFromLocalStorage(key); | ||
} catch (e) { | ||
return null; | ||
} | ||
} | ||
|
||
function setLocalStorageSafely(key, val) { | ||
try { | ||
return localStorage.setItem(key, val); | ||
return utils.setDataInLocalStorage(key, val); | ||
} catch (e) { | ||
return null; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this may require more refactoring because
encId()
, calls encodeURIComponent() and so doessetCookie()
. encoding twice could be a problem if it's not decoded twice on the other end. So maybe we refactorencId()
or maybe add an option tosetCookie()
to NOT encode.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me look into this. The id is typically passed through and decoded via a server-side process. I'll see if there is a reasonable place to account for possible double encoding in that pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@goosemanjack - would like to get this ticket merged. Should we remove the call to encId()?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a change here. Removed the call to encodeURI from encId. @goosemanjack - please review when you get a chance, but we need to merge this PR.