Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrebidServerbidAdapter to use userIdAsEids to set eids in request #4966

Merged
merged 34 commits into from
Mar 13, 2020

Conversation

pm-harshad-mane
Copy link
Contributor

Type of change

  • [ X ] Refactoring (no functional changes, no api changes)

Description of change

userIDs shared by UserId module are now available in ORTB eids format in userIdAsEids, updating PrebidServerbidAdapter to consume eids using userIdAsEids

@pm-harshad-mane
Copy link
Contributor Author

Hello @jsnellbaker ,
Could you please review this PR?

Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker requested a review from idettman March 13, 2020 19:34
@jsnellbaker jsnellbaker assigned idettman and unassigned jsnellbaker Mar 13, 2020
@jsnellbaker jsnellbaker added the needs 2nd review Core module updates require two approvals from the core team label Mar 13, 2020
@idettman idettman merged commit 00c4cb0 into prebid:master Mar 13, 2020
bmwcmw pushed a commit to criteo-forks/Prebid.js that referenced this pull request Mar 31, 2020
…ebid#4966)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* in-dev; breaking; waiting for a fix

* removed console.log

* deleted commented code
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
…ebid#4966)

* added support for pubcommon, digitrust, id5id

* added support for IdentityLink

* changed the source for id5

* added unit test cases

* changed source param for identityLink

* in-dev; breaking; waiting for a fix

* removed console.log

* deleted commented code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants