Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index Exchange: Registering user syncs #5005

Merged
merged 5 commits into from
Mar 24, 2020

Conversation

ix-prebid-support
Copy link
Contributor

@ix-prebid-support ix-prebid-support commented Mar 19, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • Added user sync callback for Index Exchange

Sample test config

pbjs.setConfig({
    userSync: {
        iframeEnabled: true,
        filterSettings: {
            iframe: {
                bidders: ['ix'],
                filter: 'include'
            }
        }
    }
});

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@ix-prebid-support
Copy link
Contributor Author

The failed unit test (in sortableAnalyticsAdapter_spec.js) is not related to the changes in this PR.

Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm waiting for circleci build to pass.

@musikele musikele merged commit fecfc2b into prebid:master Mar 24, 2020
jimee02 pushed a commit to openx/Prebid.js that referenced this pull request Mar 25, 2020
* added user sync for ix

* tests for userSync iframe drop [LIBRARY-690]

* fix user sync test

* fix lint

* added user sync info to ix bidder doc

Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com>
Co-authored-by: Pankaj Yadav <pankaj.yadav@indexexchange.com>
rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
* added user sync for ix

* tests for userSync iframe drop [LIBRARY-690]

* fix user sync test

* fix lint

* added user sync info to ix bidder doc

Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com>
Co-authored-by: Pankaj Yadav <pankaj.yadav@indexexchange.com>
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
* added user sync for ix

* tests for userSync iframe drop [LIBRARY-690]

* fix user sync test

* fix lint

* added user sync info to ix bidder doc

Co-authored-by: Zicong Zhou <zicong.zhou@indexexchange.com>
Co-authored-by: Pankaj Yadav <pankaj.yadav@indexexchange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants