Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freewheel add property vastXml to bidResponse #5015

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

xwang202
Copy link
Contributor

No description provided.

@xwang202
Copy link
Contributor Author

Hi @jsnellbaker, one of our client needs this feature asap. Can we get it merged in this coming release ?

Many thanks,

@jsnellbaker jsnellbaker merged commit 498b771 into prebid:master Mar 24, 2020
@xwang202
Copy link
Contributor Author

Hi @jsnellbaker, @jimee02 and @mike-chowla,

Thanks for merging my code!

I have another question here. I was also trying to change the property bidResponse.mediaType in our adapter, to assign the string value video when the bidrequest.mediaTypes.video is true. But the auction was automatically ended after I made this change, no response can be found in the console. Will the bidResponse.mediaType be automatically changed by your function? (I guess not, because I saw the bidResponse.mediaType is still 'banner' even if bidrequest.mediaTypes.video is true).

Do you have any clues about what happened here?

Thanks
Xuan

rjvelicaria pushed a commit to openx/Prebid.js that referenced this pull request Apr 9, 2020
iggyfisk pushed a commit to happypancake/Prebid.js that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants