Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type information to DSPX bidResponse #5021

Merged
merged 6 commits into from
Apr 1, 2020
Merged

Add type information to DSPX bidResponse #5021

merged 6 commits into from
Apr 1, 2020

Commits on Mar 24, 2020

  1. Add type information to DSPX bidResponse 

    Depending on the ad type other ad placements can be blocked or not.
For example a Skin Ad may require that all skys are blocked so they
don't overlap. For a regular display banner this isn't necessary.
    @muuki88
    muuki88 committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    9403cea View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Add type to unit test

    @muuki88
    muuki88 committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    c08ce99 View commit details
    Browse the repository at this point in the history

  2. Revert "Add type information to DSPX bidResponse" 

    This reverts commit 9403cea.
    @muuki88
    muuki88 committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    9f12caa View commit details
    Browse the repository at this point in the history

  3. Add type information to DSPX bidResponse 

    Depending on the ad type other ad placements can be blocked or not.
For example a Skin Ad may require that all skys are blocked so they
don't overlap. For a regular display banner this isn't necessary.
    @muuki88
    muuki88 committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    f1cd88c View commit details
    Browse the repository at this point in the history

  4. Revert "Add type to unit test" 

    This reverts commit c08ce99.
    @muuki88
    muuki88 committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    3408b36 View commit details
    Browse the repository at this point in the history

  5. Add type to unit test

    @muuki88
    muuki88 committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    86a1c77 View commit details
    Browse the repository at this point in the history