Eids uid string only

modules/userId/eids.js

@@ -91,7 +91,7 @@ function createEidObject(userIdData, subModuleKey) {
  let eid = {};
  eid.source = conf['source'];
  const value = utils.isFn(conf['getValue']) ? conf['getValue'](userIdData) : userIdData;
- if (value) {
+ if (utils.isStr(value)) {
  const uid = { id: value, atype: conf['atype'] };
  // getUidExt
  if (utils.isFn(conf['getUidExt'])) {

test/spec/modules/conversantBidAdapter_spec.js

@@ -470,14 +470,14 @@ describe('Conversant adapter tests', function() {
 
  // add pubcid to every entry
  requests.forEach((unit) => {
- Object.assign(unit, {userId: {pubcid: 112233, tdid: 223344, idl_env: 334455}});
+ Object.assign(unit, {userId: {pubcid: '112233', tdid: '223344', idl_env: '334455'}});
  Object.assign(unit, {userIdAsEids: createEidsArray(unit.userId)});
  });
  // construct http post payload
  const payload = spec.buildRequests(requests).data;
  expect(payload).to.have.deep.nested.property('user.ext.eids', [
- {source: 'adserver.org', uids: [{id: 223344, atype: 1, ext: {rtiPartner: 'TDID'}}]},
- {source: 'liveramp.com', uids: [{id: 334455, atype: 1}]}
+ {source: 'adserver.org', uids: [{id: '223344', atype: 1, ext: {rtiPartner: 'TDID'}}]},
+ {source: 'liveramp.com', uids: [{id: '334455', atype: 1}]}
  ]);
  });
  });

test/spec/modules/eids_spec.js

@@ -1,8 +1,8 @@
 import {createEidsArray} from 'modules/userId/eids.js';
 import {expect} from 'chai';
 
-//  Note: In unit tets cases for bidders, call the createEidsArray function over userId object that is used for calling fetchBids
-// this way the request will stay consistent and unit test cases will not need lots of changes.
+//  Note: In unit tets cases for bidders, call the createEidsArray function over userId object that is used for calling fetchBids
+// this way the request will stay consistent and unit test cases will not need lots of changes.
 
 describe('eids array generation for known sub-modules', function() {
  it('pubCommonId', function() {
@@ -158,12 +158,24 @@ describe('Negative case', function() {
  expect(newEids.length).to.equal(0);
  });
 
- it('eids array generation for known sub-module with undefined value', function() {
+ it('eids array generation for known sub-module with non-string value', function() {
  // pubCommonId
- const userId = {
+ let userId = {
  pubcid: undefined
  };
- const newEids = createEidsArray(userId);
+ let newEids = createEidsArray(userId);
+ expect(newEids.length).to.equal(0);
+ userId.pubcid = 123;
+ newEids = createEidsArray(userId);
+ expect(newEids.length).to.equal(0);
+ userId.pubcid = [];
+ newEids = createEidsArray(userId);
+ expect(newEids.length).to.equal(0);
+ userId.pubcid = {};
+ newEids = createEidsArray(userId);
+ expect(newEids.length).to.equal(0);
+ userId.pubcid = null;
+ newEids = createEidsArray(userId);
  expect(newEids.length).to.equal(0);
  });
 });