-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Size Mapping V2 supports 'Identical Ad Units' #5062
Conversation
This PR is ready for review. Only thing that I'd have liked to do was remove some ambiguity from the log messages. For example: If we have two Identical ad units (sharing the same code), from the log messages it is kind of hard to determine which ad unit got disabled, or which ad unit got an error, since ad unit code is no longer a unique identifier. In the screenshot above, we have two identical ad units sharing the same code Once this PR is merged, I'll create a separate github issue to keep track of this behaviour and provide a fix in a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks pretty good!
I am always a big fan of improving our logging.
* add support for identical ad units and improve log messages * slight change in log message presentation * fix typo * document return value type
* add support for identical ad units and improve log messages * slight change in log message presentation * fix typo * document return value type
Type of change
Description of change
This PR introduces support for 'Identical Ad Unit' declaration in Size Mapping V2. An Identical Ad Unit is an ad unit with the same
code
as one of the existing ad units but differentmediaTypes
object.Example of Identical Ad Units:
The example above has two identical ad units with the same code
ad-code-1
but with different values formediaTypes
object.The PR also improves the log messages generated by Size Mapping V2, tries to make it more intuitive and easy to understand.
Resolves #5044