getLoadTimeDistribution-sorting-fix #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the load time events are passed through to GA as follows: 0-200ms 200-300ms 300-400ms 400-500ms 500-600ms 600-800ms 800-1000ms 1000-1200ms 1200-1500ms 1500-2000ms 2000ms above Unfortunately, this means they are sorted like this in the GA sheet: 0-200ms 1000-1200ms 1200-1500ms 1500-2000ms 2000ms above 200-300ms 300-400ms 400-500ms 500-600ms 600-800ms 800-1000ms This makes the Load Time Distribution chart difficult to read. I've fixed this within my own prebid.js file by adding a leading 0 to the 200-1000ms ranges, e.g. '0200-300ms'. It appears as though in the past the 1000ms+ ranges were entered as follows solving for this issue as well: t2:1000-1200ms t2:1200-1500ms t2:1500-2000ms t2:2000ms above
|
@CLKeenan |
|
I'm going to merge this, but it might alter existing data so buyer beware. |
olafbuitelaar
pushed a commit
to olafbuitelaar/Prebid.js
that referenced
this pull request
Aug 13, 2016
Currently, the load time events are passed through to GA as follows: 0-200ms 200-300ms 300-400ms 400-500ms 500-600ms 600-800ms 800-1000ms 1000-1200ms 1200-1500ms 1500-2000ms 2000ms above Unfortunately, this means they are sorted like this in the GA sheet: 0-200ms 1000-1200ms 1200-1500ms 1500-2000ms 2000ms above 200-300ms 300-400ms 400-500ms 500-600ms 600-800ms 800-1000ms This makes the Load Time Distribution chart difficult to read. I've fixed this within my own prebid.js file by adding a leading 0 to the 200-1000ms ranges, e.g. '0200-300ms'. It appears as though in the past the 1000ms+ ranges were entered as follows solving for this issue as well: t2:1000-1200ms t2:1200-1500ms t2:1500-2000ms t2:2000ms above
protonate
pushed a commit
that referenced
this pull request
Aug 20, 2016
Currently, the load time events are passed through to GA as follows: 0-200ms 200-300ms 300-400ms 400-500ms 500-600ms 600-800ms 800-1000ms 1000-1200ms 1200-1500ms 1500-2000ms 2000ms above Unfortunately, this means they are sorted like this in the GA sheet: 0-200ms 1000-1200ms 1200-1500ms 1500-2000ms 2000ms above 200-300ms 300-400ms 400-500ms 500-600ms 600-800ms 800-1000ms This makes the Load Time Distribution chart difficult to read. I've fixed this within my own prebid.js file by adding a leading 0 to the 200-1000ms ranges, e.g. '0200-300ms'. It appears as though in the past the 1000ms+ ranges were entered as follows solving for this issue as well: t2:1000-1200ms t2:1200-1500ms t2:1500-2000ms t2:2000ms above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the load time events are passed through to GA as follows:
0-200ms
200-300ms
300-400ms
400-500ms
500-600ms
600-800ms
800-1000ms
1000-1200ms
1200-1500ms
1500-2000ms
2000ms above
Unfortunately, this means they are sorted like this in the GA sheet:
0-200ms
1000-1200ms
1200-1500ms
1500-2000ms
2000ms above
200-300ms
300-400ms
400-500ms
500-600ms
600-800ms
800-1000ms
This makes the Load Time Distribution chart difficult to read. I've fixed this within my own prebid.js file by adding a leading 0 to the 200-1000ms ranges, e.g. '0200-300ms'. It appears as though in the past the 1000ms+ ranges were entered as follows solving for this issue as well:
t2:1000-1200ms
t2:1200-1500ms
t2:1500-2000ms
t2:2000ms above