Remove leftover return value from requestBids #5160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkendall07
approved these changes
Apr 23, 2020
mkendall07
added
the
needs 2nd review
Fawke
added
LGTM
and removed
needs 2nd review
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Someone mentioned that
requestBidsis not propertly returning anything (it'sundefined). This is because it is an async hook and async hooks cannot return a value on account of them being asynchronous. The return value is a leftover addition that was added to support the oldpre1apimodule, but it was never documented and is not part of our public API. This pull-request is to remove it so it doesn't confuse anyone else.