Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Criteo - partially restore adapter before PR #4518 following performance issues #5376

Merged
merged 4 commits into from
Jul 8, 2020

Conversation

leonardlabat
Copy link
Contributor

@leonardlabat leonardlabat commented Jun 16, 2020

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

Partially restore adapter before PR #4518 following performance issues

@leonardlabat leonardlabat changed the title Criteo - partially restore adapter before PR #4518 following performa… Criteo - partially restore adapter before PR #4518 following performance issues Jun 16, 2020
@robertrmartinez robertrmartinez self-requested a review June 22, 2020 18:33
@robertrmartinez robertrmartinez self-assigned this Jun 22, 2020
@leonardlabat
Copy link
Contributor Author

Hello

Kindle reminder on this PR. Is there anything blocking left ? Thanks

@robertrmartinez
Copy link
Collaborator

@leonardlabat I will review and merge this.

For reference, on slack @mkendall07 affirmed he initially approved the usage of eval and we will continue to allow it for this special case.

modules/criteoBidAdapter.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one last comment.

modules/criteoBidAdapter.js Outdated Show resolved Hide resolved
@robertrmartinez robertrmartinez merged commit 3920e1a into prebid:master Jul 8, 2020
sbrosinski added a commit to smaato/Prebid.js that referenced this pull request Jul 10, 2020
* 'master' of github.com:prebid/Prebid.js: (39 commits)
  Increment pre version
  Prebid 3.25.0 release
  Add lotame id system (prebid#5388)
  Change endpoint (prebid#5459)
  ozone 2.4.0 adapter updates (prebid#5421)
  Update AppNexus usersync script (prebid#5473)
  Eplanning fix: decode parameters (prebid#5448)
  Teads adapter : Support page referrer and network bandwidth (prebid#5430)
  Merge Valueimpression Bid Adapter to Quantumdex Bid Adapter (prebid#5405)
  Criteo - partially restore adapter before PR prebid#4518 following performance issues (prebid#5376)
  onetagBidAdapter: outstream support (prebid#5435)
  Vidazoo Adapter: Feature/bidder-version (prebid#5384)
  adform and adformOpenRTB bid adapters: Added support for userId modules (prebid#5425)
  proxistore bid adapter: delay request to server by 5 min if there were no bids (prebid#5379)
  Vidazoo Adapter: Feature/subdomain (prebid#5446)
  Inskin Bid adapter small changes (prebid#5373)
  Revert "add AMX adapter (prebid#5383)" (prebid#5455)
  ATS-change logError to logInfo type (prebid#5443)
  ATS-identityLinkId - add additional info logging events (prebid#5442)
  Update padsquad for meta.advertiserDomains (prebid#5439)
  ...
sbrosinski added a commit to smaato/Prebid.js that referenced this pull request Jul 10, 2020
* smaato-adapter: (40 commits)
  Smaato: Fix test data
  Increment pre version
  Prebid 3.25.0 release
  Add lotame id system (prebid#5388)
  Change endpoint (prebid#5459)
  ozone 2.4.0 adapter updates (prebid#5421)
  Update AppNexus usersync script (prebid#5473)
  Eplanning fix: decode parameters (prebid#5448)
  Teads adapter : Support page referrer and network bandwidth (prebid#5430)
  Merge Valueimpression Bid Adapter to Quantumdex Bid Adapter (prebid#5405)
  Criteo - partially restore adapter before PR prebid#4518 following performance issues (prebid#5376)
  onetagBidAdapter: outstream support (prebid#5435)
  Vidazoo Adapter: Feature/bidder-version (prebid#5384)
  adform and adformOpenRTB bid adapters: Added support for userId modules (prebid#5425)
  proxistore bid adapter: delay request to server by 5 min if there were no bids (prebid#5379)
  Vidazoo Adapter: Feature/subdomain (prebid#5446)
  Inskin Bid adapter small changes (prebid#5373)
  Revert "add AMX adapter (prebid#5383)" (prebid#5455)
  ATS-change logError to logInfo type (prebid#5443)
  ATS-identityLinkId - add additional info logging events (prebid#5442)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants