Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ayl gdp rdefault value #5391

Merged
merged 21 commits into from
Jun 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
32adbfc
Merge remote-tracking branch 'origin/master'
guiann May 29, 2019
140b538
Remove useless bidderCode in bid response
guiann May 29, 2019
1bd5a3a
Merge remote-tracking branch 'guiann-prebid/master'
guiann May 29, 2019
613824c
Merge remote-tracking branch 'origin/master'
guiann Jun 13, 2019
8fb7857
Merge remote-tracking branch 'origin/master'
guiann Jul 18, 2019
21734b3
Merge branch 'master' into adYouLike-handleMultipleSizes
guiann Jul 18, 2019
e4a5f63
send all the available sizes in the bid request
guiann Jul 22, 2019
111dc49
Merge branch 'adYouLike-handleMultipleSizes'
guiann Jul 22, 2019
908eaab
Merge remote-tracking branch 'origin/master'
guiann Jul 22, 2019
edf4cd3
Use the banner sizes if given
guiann Jul 25, 2019
008ded4
avoid compatibility issue with old bid format
guiann Jul 25, 2019
9664b1a
Merge remote-tracking branch 'origin/master'
guiann Oct 10, 2019
b46765a
Merge remote-tracking branch 'Adyoulike/master'
guiann Dec 24, 2019
1a4f452
Merge remote-tracking branch 'Adyoulike/master'
guiann Dec 24, 2019
c8cf2fc
Merge remote-tracking branch 'origin/master'
guiann Jan 8, 2020
24af97c
Merge remote-tracking branch 'origin/master'
guiann Jan 8, 2020
f945f2a
Merge remote-tracking branch 'origin/master'
guiann Apr 14, 2020
0eb05af
Remove gdpr default apply value
guiann Apr 14, 2020
c1c94e3
Merge remote-tracking branch 'origin/master' into AYL-GDPRdefaultValue
guiann Jun 18, 2020
0e5c976
minor: use better variable name
guiann Jun 18, 2020
7a2895a
Add unit test on unspecified gdprApplies
guiann Jun 18, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions modules/adyoulikeBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const spec = {
if (bidderRequest && bidderRequest.gdprConsent) {
payload.gdprConsent = {
consentString: bidderRequest.gdprConsent.consentString,
consentRequired: (typeof bidderRequest.gdprConsent.gdprApplies === 'boolean') ? bidderRequest.gdprConsent.gdprApplies : true
consentRequired: (typeof bidderRequest.gdprConsent.gdprApplies === 'boolean') ? bidderRequest.gdprConsent.gdprApplies : null
};
}

Expand Down Expand Up @@ -80,7 +80,7 @@ export const spec = {

try {
bidRequests = JSON.parse(request.data).Bids;
} catch (e) {
} catch (err) {
// json error initial request can't be read
}

Expand Down
23 changes: 23 additions & 0 deletions test/spec/modules/adyoulikeBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,29 @@ describe('Adyoulike Adapter', function () {
expect(payload.uspConsent).to.exist.and.to.equal(uspConsentData);
});

it('should not set a default value for gdpr consentRequired', function () {
let consentString = 'BOJ8RZsOJ8RZsABAB8AAAAAZ+A==';
let uspConsentData = '1YCC';
let bidderRequest = {
'auctionId': '1d1a030790a475',
'bidderRequestId': '22edbae2733bf6',
'timeout': 3000,
'gdprConsent': {
consentString: consentString
},
'uspConsent': uspConsentData
};

bidderRequest.bids = bidRequestWithSinglePlacement;

const request = spec.buildRequests(bidRequestWithSinglePlacement, bidderRequest);
const payload = JSON.parse(request.data);

expect(payload.gdprConsent).to.exist;
expect(payload.gdprConsent.consentString).to.exist.and.to.equal(consentString);
expect(payload.gdprConsent.consentRequired).to.be.null;
});

it('sends bid request to endpoint with single placement', function () {
const request = spec.buildRequests(bidRequestWithSinglePlacement, bidderRequest);
const payload = JSON.parse(request.data);
Expand Down