Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TrueReach Bidder Adapter #5423

Merged
merged 9 commits into from
Jul 17, 2020
Merged

TrueReach Bidder Adapter #5423

merged 9 commits into from
Jul 17, 2020

Conversation

mmprebid
Copy link
Contributor

@mmprebid mmprebid commented Jun 26, 2020 •
edited
Loading

Type of change

  • New bidder adapter

Description of change

  • test parameters for validating bids
{
  bidder: 'truereach',
  params: {
     site_id: '0142010a-8400-1b01-72cb-a553b9000009',
     bidfloor: 0.1
  }
}

Related prebid.github.io PR Link

@mmprebid mmprebid mentioned this pull request Jun 29, 2020
Merged
@mike-chowla mike-chowla requested a review from idettman July 2, 2020 23:36
@patmmccann
Copy link
Collaborator

Can you copy adomain from your response to bid.meta.advertiserDomains as per http://prebid.org/dev-docs/bidder-adaptor.html#interpreting-the-response

@mmprebid
Copy link
Contributor Author

mmprebid commented Jul 7, 2020

@patmmccann we have added advertiserDomains in the new commit. Please verify.

@mmprebid
Copy link
Contributor Author

@patmmccann / @idettman / @mike-chowla Kindly let us know the review progress or any issues.

@bretg bretg requested review from Fawke and removed request for idettman July 16, 2020 01:12
@bretg bretg assigned Fawke and unassigned idettman Jul 16, 2020
@bretg
Copy link
Collaborator

bretg commented Jul 16, 2020

@idettman is backed up, so assigning over to @Fawke

Fawke
Fawke requested changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@Fawke Fawke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Only thing that needs to change is the BIDDER_URL field. From, Prebid v3.0 onwards, it's mandatory to use a secure bidder endpoint.

modules/truereachBidAdapter.js Outdated

const SUPPORTED_AD_TYPES = [BANNER];
const BIDDER_CODE = 'truereach';
const BIDDER_URL = '//ads.momagic.com/exchange/openrtb25/';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BIDDER_URL must use https

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Fawke We have updated BIDDER_URL to use https always. Please verify.

@mmprebid mmprebid requested a review from Fawke July 17, 2020 05:53
@Fawke Fawke merged commit bab94f0 into prebid:master Jul 17, 2020
@Fawke Fawke added LGTM and removed needs update labels Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fawke Fawke Fawke approved these changes

Assignees

@Fawke Fawke

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mmprebid @patmmccann @bretg @Fawke @idettman @nitinmomagic @arnav-mm