-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oneVideo Adapter End2End Testing Parameter Support (SAPR-13942) #5466
Conversation
AFAIK, the failed ci/circleci: build test is Not related to the changes of this PR |
@adam-browning LGTM |
All tests and checks pass after pulling upstream and merging master today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a quick question regarding the value being passed in the request object when this e2e test flag is enabled. Please take a look when you have the chance.
Thanks!
Thanks for the confirmation. When you get a chance, can you please take a look at the new conflicts and resolve them? They're likely the result from the other PR just getting merged. We should be good to merge this PR once the conflicts are cleaned up. |
Hi @jsnellbaker, |
Hi @jsnellbaker, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. LGTM
Type of change
Description of change
oneVideoBidAdapter now supports a new parameter to force outbound bid-request settings for self severed testing By passing "bid.params.video.e2etest = true".
Important: 'e2etest: ture` is a sumpliment to the mandatory parameters, it cannot replace them.
When applying
e2etest: ture
the adapter will switch to testing mode and send an outbound bid-request to our test our US west coast server "HBExchange" Exchange endpointThe feature overrides base settings like ENDPOINT, width, height, pubid, page, referrer to minimize testing costs and time on the publishers end.
Test parameters for validating bids
Other information
Hi @DeepthiNeeladri,
Could you please review this feature
Thank you!
Adam