Undertone 24910 video in prebid #5485
Conversation
…r is now optional and not mandatory - undertoneBidAdapter.js * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js
…r is now optional and not mandatory - undertoneBidAdapter.js * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js
…r is now optional and not mandatory - undertoneBidAdapter.js * Updated undertone bid adapter tests accordingly - undertoneBidAdapter_spec.js
|
@AnnaPerion - please fix your indentation -- it failed the lint stage. |
|
@AnnaPerion this appears to break undertone bidding on multiformat units. Please see first in content unit at https://cafedelites.com/best-chimichurri-chicken Your volume on this unit is down nearly 100% with us since this commit was merged. |
| @@ -120,8 +122,20 @@ export const spec = { | |||
| sizes: bidReq.sizes, | |||
| params: bidReq.params | |||
| }; | |||
| const videoMediaType = deepAccess(bidReq, 'mediaTypes.video'); | |||
There was a problem hiding this comment.
this should potentially say & deepAccess(bidReq, 'mediaTypes.video.context') != 'outstream or something of the sort
There was a problem hiding this comment.
@patmmccann i believe our team already reached out to you via email, however please reach out to pubams@undertone.com for further discussion/ next steps
There was a problem hiding this comment.
@oranperion this is a community issue, not just our account. What is the status of this? Breaking changes should be reserved for major version updates and this change breaks your support of multiformat ad slots.
There was a problem hiding this comment.
@patmmccann issue already been solved on backend, there is already high fill rate on the placement id 2002001, and an email about this information been sent to you and your company last week, where a member of your company - Isaiah Ward iward@cafemedia.com conform issue resolved
There was a problem hiding this comment.
Thanks for looping in the community here, glad all is resolved!
##Type of change
Description of change