Adagio bid adapter 2.3.0 #5498
Merged
Adagio bid adapter 2.3.0 #5498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osazos
force-pushed
the
adagio-feature/adagioBidAdapter-2.3.0
branch
from
b6cf02d to
5a08fa8
Compare
|
Hi @bmwcmw do not hesitate to ping me if you need more information to review. |
|
Hi @bmwcmw, I'm sure you are busy so sorry for asking, but could you give an ETA about the review of this PR? |
- use SafeFrame API to compute features - compute page_dimensions in SafeFrame context - Remove pageDimensions feature with cross-domain iframe
Use the real page width instead of the viewport one
osazos
force-pushed
the
adagio-feature/adagioBidAdapter-2.3.0
branch
from
5a08fa8 to
7236ba8
Compare
|
(msm0504 is out this week - re-assigning) |
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
* adagioBidAdapter: support cross-origin iframe context - use SafeFrame API to compute features - compute page_dimensions in SafeFrame context - Remove pageDimensions feature with cross-domain iframe * adagiobidAdapter: refactoring and improve tests * Fix getPageDimensions() width detection Use the real page width instead of the viewport one * Improve getSlotPosition() in postBid context * Load adagio script regarding TCF2 storage enforcement * Fix CI tests
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
This reverts commit 742baed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR is about:
contact email of the adapter’s maintainer: dev@adagio.io