Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adagio bid adapter 2.3.0 #5498

Merged
merged 6 commits into from
Aug 12, 2020
Merged

Adagio bid adapter 2.3.0 #5498

merged 6 commits into from
Aug 12, 2020

Conversation

osazos
Copy link
Collaborator

@osazos osazos commented Jul 15, 2020 •
edited
Loading

Type of change

  • Feature
  • Refactoring (no functional changes, no api changes)
  • Other

Description of change

This PR is about:

  • cross domain iframe (w/ and w/o safeFrame api) compliance
  • Adagio internal functions improvements
  • refactoring in order to facilitate testing (note adagioBidAdapter_spec.js file has been rewritten)
  • better loading of our external script regarding TCF2 storage enforcement

contact email of the adapter’s maintainer: dev@adagio.io

@osazos osazos force-pushed the adagio-feature/adagioBidAdapter-2.3.0 branch from b6cf02d to 5a08fa8 Compare July 15, 2020 21:31
@bretg bretg requested a review from bmwcmw July 16, 2020 00:57
@osazos
Copy link
Collaborator Author

osazos commented Jul 23, 2020

Hi @bmwcmw do not hesitate to ping me if you need more information to review.
Thanks

@osazos
Copy link
Collaborator Author

osazos commented Jul 30, 2020

Hi @bmwcmw, I'm sure you are busy so sorry for asking, but could you give an ETA about the review of this PR?
Thanks

@osazos
adagioBidAdapter: support cross-origin iframe context
09bd210 
- use SafeFrame API to compute features
- compute page_dimensions in SafeFrame context
- Remove pageDimensions feature with cross-domain iframe
@osazos
adagiobidAdapter: refactoring and improve tests
2add17d
@osazos
Fix getPageDimensions() width detection
c05a649 
Use the real page width instead of the viewport one
@osazos
Improve getSlotPosition() in postBid context
283d32a
@osazos
Load adagio script regarding TCF2 storage enforcement
cc44362
@osazos
Fix CI tests
7236ba8
@osazos osazos force-pushed the adagio-feature/adagioBidAdapter-2.3.0 branch from 5a08fa8 to 7236ba8 Compare July 31, 2020 08:21
@osazos
Copy link
Collaborator Author

osazos commented Aug 7, 2020

Hi there, what the point about this PR?
I have no news since @bmwcmw has been assigned to the review.
cc @bretg, @bmwcmw

@bretg bretg requested a review from msm0504 August 7, 2020 13:40
@bretg bretg assigned msm0504 and unassigned bmwcmw Aug 7, 2020
@bretg bretg requested review from Fawke and removed request for bmwcmw and msm0504 August 7, 2020 13:40
@bretg bretg assigned Fawke and unassigned msm0504 Aug 11, 2020
@bretg
Copy link
Collaborator

bretg commented Aug 11, 2020

(msm0504 is out this week - re-assigning)

Fawke
Fawke approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke added LGTM and removed needs review labels Aug 12, 2020
@Fawke Fawke merged commit b591906 into prebid:master Aug 12, 2020
@osazos osazos deleted the adagio-feature/adagioBidAdapter-2.3.0 branch November 26, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fawke Fawke Fawke approved these changes

Assignees

@Fawke Fawke

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@osazos @bretg @Fawke @bmwcmw @msm0504