Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vidazoo Adapter: Feature/alternate-param-names #5527

Merged
merged 10 commits into from
Jul 23, 2020

Conversation

uditalias
Copy link
Contributor

Type of change

  • Refactoring (no functional changes, no api changes)

Description of change

  • We added the option to pass the cId, pId, subDomain params with alternate variations.
  • Added tests

@uditalias uditalias changed the title Feature/alternate param names Vidazoo Adapter: Feature/alternate-param-names Jul 22, 2020
Copy link
Member

@mkendall07 mkendall07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkendall07 mkendall07 merged commit 0403ba7 into prebid:master Jul 23, 2020
mkendall07 added a commit that referenced this pull request Jul 23, 2020
mkendall07 added a commit that referenced this pull request Jul 23, 2020
@mkendall07
Copy link
Member

hey @uditalias
Can you resubmit this to master and 3.27.x-legacy branch? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants