Add sspBC adapter #5531

wojciech-bialy-wpm · 2020-07-22T15:37:14Z

Type of change

New bidder adapter

Description of change

Add bidder adapter used by Wirtualna Polska Media and it's partners

test parameters for validating bids

   {
      code: 'banner-div',
      mediaTypes: {
        banner: {
          sizes: [[970,300],
                        [750,300],
                        [750,200],
                        [750,100],
                        [300,250]]
        }
      },
      bids: [{
         bidder: 'sspBC',
         params: {
                    id: '003',
                    siteId: '235860',
                    test: 1          
         }
       }]
   }

Be sure to test the integration with your adserver using the Hello World sample page.

contact email of the adapter’s maintainer: wojciech.bialy@grupawp.pl
official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

A link to a PR on the docs repo at https://github.com/prebid/prebid.github.io/

patmmccann · 2020-07-22T16:07:07Z

modules/sspBCAdapter.js

+              width: serverBid.w,
+              height: serverBid.h,
+              bidderCode: BIDDER_CODE,
+              mediaType: 'banner',


please create meta.advertiserDomains

see http://prebid.org/dev-docs/bidder-adaptor.html

Understood! I've looked into it, and while our JSON endpoint does not return bid metadata, it should be available server-side (as underlying logic is using openRTB protocol).

I've created a change request, will update adapter & pull request once it's done.

Adapter & test have been updated, bids now have meta.advertiserDomains property:
meta: { advertiserDomains: serverBid.adomain, },

mike-chowla · 2020-07-29T01:12:29Z

I'm not getting a test bid back

Request URL: https://ssp.wp.pl/bidder/?cs=true&bdver=4.4&pbver=3.27.0-pre&inver=0
Request Body
{"id":"b05ddc9f-742a-4f23-aed3-4bbd67ffd1cd","site":{"id":"235911","page":"http://mike3.pubmatic.com:9999/integrationExamples/gpt/hello_world.html","domain":"mike3.pubmatic.com"},"imp":[{"id":"005","banner":{"format":[{"w":300,"h":250},{"w":300,"h":600}],"id":"2dd143f2e116ad"},"tagid":"005"}],"tmax":450,"user":{"data":[{"id":"12","name":"NetInfo","segment":[{"name":"CH-Ect","value":"4g"},{"name":"CH-Rtt","value":"100"},{"name":"CH-Downlink","value":"5.7"},{"name":"CH-Dpr","value":"1"},{"name":"CH-ViewportWidth","value":"1787"}]}]},"regs":{}}

…set test mode in adexchange, read site SN from bid response

… bid.meta

wojciech-bialy-wpm · 2020-08-04T09:03:12Z

"Not getting a test bid back" - this has been resolved. The was an issue with DSP not sending test ad. We're now enforcing test demand by adding test: 1 to bid parameters:
"bids": [{ "bidder": "sspBC", "params": { "id": "003", "siteId": "235860", "test": 1 } }],

I've created two simple test pages:

one where prebid creative is rendered in a friendly frame: https://bdr.wpcdn.pl/tests/bidderv4/test-adapter_google.html
and one where we're using Google Ad Manager, and Universal Creative in a safeframe: https://bdr.wpcdn.pl/tests/bidderv4/test-adapter_google.html

mike-chowla · 2020-08-07T23:42:35Z

I'm still not getting a bid back. Here's the request body:

{"id":"3b57cb24-323e-47c8-aefb-a71f215d4d33","site":{"id":"235860","page":"http://mike3.pubmatic.com:9999/integrationExamples/imac/hello_world.html?pbjs_debug=true","domain":"mike3.pubmatic.com"},"imp":[{"id":"003","banner":{"format":[{"w":300,"h":250},{"w":300,"h":600}],"id":"2728ae76cdde47"},"tagid":"003"}],"tmax":450,"user":{"data":[{"id":"12","name":"NetInfo","segment":[{"name":"CH-Ect","value":"4g"},{"name":"CH-Rtt","value":"50"},{"name":"CH-Downlink","value":"10"},{"name":"CH-Dpr","value":"2"},{"name":"CH-ViewportWidth","value":"1787"}]}]},"regs":{},"test":1}

wojciech-bialy-wpm · 2020-08-10T10:27:34Z

@mike-chowla

Regarding not getting a bid back: The adapter accepts gdpr-compliant requests only. It will not forward any requests that do not have consent for vendor BusinessClick (vendor Id 676), and purposes 1 & 3.
This, unfortunately, overrides any test settings.

In above case, gdpr data is not supplied, and therefore request is not sent to SSPs.

Could You append GDPR data to the request? If You want, You can use this javascript snippet, that will set up IAB v1 compliant cmp API:
https://bdr.wpcdn.pl/tests/static_cmp.js

We can change the logic (so that test requests will be sent regardless of gdpr status), but this might take some time.

patmmccann · 2020-08-12T15:50:20Z

Why don't you hard code a consent string into your unit tests

wojciech-bialy-wpm · 2020-08-17T15:06:43Z

@patmmccann Thank You, good idea!

I've added two more tests, that will perfrom xhr call to our json endpoint. One with test settings & hardcoded consent, one with same settings but no gdpr.

mike-chowla

Please remove XHR from tests

mike-chowla · 2020-08-17T17:51:27Z

test/spec/modules/sspBCAdapter_spec.js

+    const requestSingleTestNoGDPR = spec.buildRequests(bids_test, bidRequestTestNoGDPR);
+
+    it('should return test ad when request is made with test:1 and gdpr data', function (done) {
+      const xhr = new XMLHttpRequest();


There should be no XHR or network requests in your tests. Our tests will never pass if we are reliant on 250 vendor endpoints to be working. All responses should be mocked in the test frame.out

mike-chowla · 2020-08-17T17:51:37Z

test/spec/modules/sspBCAdapter_spec.js

+    });
+
+    it('should return no ads for request without gdpr, regardless of test settings', function (done) {
+      const xhr = new XMLHttpRequest();


@mike-chowla I've removed ajax tests. I have left bidRequestTest and bidRequestTestNoGDPR, which should provide configs that

always receive one test ad (bidRequestTest)

never receive test ad, due to the lack of GDDPR (bidRequestTestNoGDPR)

Could You use config provided in bidRequestTest and check if you're getting a bid response?

patmmccann · 2020-08-17T20:14:22Z

@patmmccann Thank You, good idea!

I've added two more tests, that will perfrom xhr call to our json endpoint. One with test settings & hardcoded consent, one with same settings but no gdpr.

Sorry, Mike makes a good point, my mistake.

Update sspbc-adapter branch

wojciech-bialy-wpm · 2020-08-18T09:28:01Z

sspbc-adapter branch has been updated

Update sspbc-adapter branch

wojciech-bialy-wpm · 2020-08-24T07:41:23Z

@mike-chowla

I've updated sspbc-adapter branch - it should now incorporate all commits from Prebid.js/master as of 24.8.2020 08:40 GMT

Is there anything else that needs to be updated?

* add sspbc adapter * tests for sspbc adapter * sspBC adapter v4.5: set correct creativeId, add adomain to bid.meta, set test mode in adexchange, read site SN from bid response * sspBC adapter v4.5: set meta.advertiserDomains, update test to expect bid.meta * sspBC Adapter: add ajax tests (test ad with & without gdpr) * sspBC Adapter: remove ajax tests Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>

This reverts commit 6c61aa9.

Wojciech Biały added 2 commits July 22, 2020 16:14

add sspbc adapter

59a3934

tests for sspbc adapter

a28b263

patmmccann reviewed Jul 22, 2020

View reviewed changes

smenzer assigned mike-chowla Jul 23, 2020

MartianTribe mentioned this pull request Jul 23, 2020

Add sspBC adapter prebid/prebid.github.io#2157

Merged

mike-chowla self-requested a review July 29, 2020 01:10

mike-chowla added the not receiving bids label Jul 29, 2020

Wojciech Biały added 2 commits August 4, 2020 09:27

sspBC adapter v4.5: set correct creativeId, add adomain to bid.meta, …

2350cc8

…set test mode in adexchange, read site SN from bid response

sspBC adapter v4.5: set meta.advertiserDomains, update test to expect…

dc4d0c4

… bid.meta

sspBC Adapter: add ajax tests (test ad with & without gdpr)

7672bbc

mike-chowla removed the not receiving bids label Aug 17, 2020

mike-chowla requested changes Aug 17, 2020

View reviewed changes

mike-chowla added the needs update label Aug 17, 2020

sspBC Adapter: remove ajax tests

a569a8d

Merge pull request #2 from prebid/master

72269fd

Update sspbc-adapter branch

Merge pull request #3 from prebid/master

e87dd78

Update sspbc-adapter branch

mike-chowla approved these changes Aug 24, 2020

View reviewed changes

mike-chowla removed the needs update label Aug 24, 2020

mike-chowla merged commit 29bd8de into prebid:master Aug 24, 2020

BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020

Revert "Add sspBC adapter (prebid#5531)"

3431ad0

This reverts commit 6c61aa9.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add sspBC adapter #5531

Add sspBC adapter #5531

wojciech-bialy-wpm commented Jul 22, 2020 •

edited

Loading

patmmccann Jul 22, 2020

patmmccann Jul 22, 2020

wojciech-bialy-wpm Jul 24, 2020

wojciech-bialy-wpm Aug 4, 2020

mike-chowla commented Jul 29, 2020 •

edited

Loading

wojciech-bialy-wpm commented Aug 4, 2020

mike-chowla commented Aug 7, 2020

wojciech-bialy-wpm commented Aug 10, 2020

patmmccann commented Aug 12, 2020

wojciech-bialy-wpm commented Aug 17, 2020

mike-chowla left a comment

mike-chowla Aug 17, 2020

mike-chowla Aug 17, 2020

wojciech-bialy-wpm Aug 17, 2020

patmmccann commented Aug 17, 2020

wojciech-bialy-wpm commented Aug 18, 2020

wojciech-bialy-wpm commented Aug 24, 2020

Add sspBC adapter #5531

Add sspBC adapter #5531

Conversation

wojciech-bialy-wpm commented Jul 22, 2020 • edited Loading

Type of change

Description of change

patmmccann Jul 22, 2020

Choose a reason for hiding this comment

patmmccann Jul 22, 2020

Choose a reason for hiding this comment

wojciech-bialy-wpm Jul 24, 2020

Choose a reason for hiding this comment

wojciech-bialy-wpm Aug 4, 2020

Choose a reason for hiding this comment

mike-chowla commented Jul 29, 2020 • edited Loading

wojciech-bialy-wpm commented Aug 4, 2020

mike-chowla commented Aug 7, 2020

wojciech-bialy-wpm commented Aug 10, 2020

patmmccann commented Aug 12, 2020

wojciech-bialy-wpm commented Aug 17, 2020

mike-chowla left a comment

Choose a reason for hiding this comment

mike-chowla Aug 17, 2020

Choose a reason for hiding this comment

mike-chowla Aug 17, 2020

Choose a reason for hiding this comment

wojciech-bialy-wpm Aug 17, 2020

Choose a reason for hiding this comment

patmmccann commented Aug 17, 2020

wojciech-bialy-wpm commented Aug 18, 2020

wojciech-bialy-wpm commented Aug 24, 2020

wojciech-bialy-wpm commented Jul 22, 2020 •

edited

Loading

mike-chowla commented Jul 29, 2020 •

edited

Loading