purposes in call for invibes #5533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rcheptanariu please review it before anyone else! |
| @@ -443,7 +438,6 @@ invibes.Uid = { | |||
| } | |||
| }; | |||
|
|
|||
| let cookieDomain; | |||
| invibes.getCookie = function (name) { | |||
There was a problem hiding this comment.
for reading cookies please use the storage manager
There was a problem hiding this comment.
change request was implemented please review for merge asap :)
|
change request was implemented please review for merge asap :) |
|
This pull request introduces 1 alert when merging 25be9eb into db02d8a - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 0410982 into db02d8a - view on LGTM.com new alerts:
|
|
@robertrmartinez please review asap |
|
This pull request introduces 1 alert when merging 19515df into f0e4433 - view on LGTM.com new alerts:
|
robertrmartinez
approved these changes
Aug 20, 2020
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
* added tcf 2.0 * Updated adapter to support gdprEnforcement * reverted storage manager initialization * add purposes in call * send purposes in string array * InvibesBidAdapter - gdpr updates * [InvibesBidAdapter] GDPR - purpose adjustments * [InvibesBidAdapter] fixed tests for new alg & reordered adapter checks * add tc string Co-authored-by: florin_nedelcu_invibes <florin.nedelcu@invibes.com> Co-authored-by: Cristian Grigoras <cristian.grigoras@invibes.com> Co-authored-by: raduchept <radu.cheptanariu@invibes.com>
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
This reverts commit e910d68.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information