JW Player Real Time Data Provider #5537
Conversation
|
This pull request introduces 1 alert when merging 6c967941b3f6c73742eb740387104a1a71d19d96 into eb467f4 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 34b9f9b96b33dcd4a9b1de304392e8c5402af1da into c933c4f - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 00f32e3cb8d65d2bc088166f46d842fa28519311 into c933c4f - view on LGTM.com new alerts:
|
| fetchTargetingInformation(params); | ||
| }); | ||
|
|
||
| submodule('realTimeData', jwplayerSubmodule); |
There was a problem hiding this comment.
@patmmccann this is the line where we register as an RTD submodule
There was a problem hiding this comment.
ty! how do you like this format?
There was a problem hiding this comment.
Do you mean how do I like having the jwplayer module be a submodule of an existing module ? I think it's great for reusability and consistency across all rtd providers. Thank you for suggesting this approach.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
karimMourra
force-pushed
the
task/AD-775-rearch
branch
from
00f32e3
to
e444781
Compare
|
This pull request introduces 1 alert when merging e444781c16495557c485c26d93bb995159d090f0 into db02d8a - view on LGTM.com new alerts:
|
karimMourra
force-pushed
the
task/AD-775-rearch
branch
from
e444781
to
5bcb160
Compare
|
@idettman the PR that was blocking this PR has been merged. Could you please review ? |
|
@robertrmartinez Could you please review this PR ? It was blocked by #5519 |
Type of change
Description of change
Adds the jwplayer RTD Provider module which allows Ad Bidders to obtain JW Player's Video Ad Targeting information.
It is a submodule of the RTD Module.
The module will fetch segments for the media ids present in the prebid config when the module loads. When bid requests are made, it will check for params in the AdUnit set by the publisher and will set the corresponding targeting information to the real time data returned in
getData.karim@jwplayer.com
Other information
The base branch of this PR is #5519 and should be merged after it. The only changes made to it are the addition of
jwplayerRtdProvider.jsandjwplayerRtdProvider_spec.js, and the modification of.submodules.json