Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New request format for The Media Grid Bid Adapter #5541

Merged
merged 21 commits into from
Jul 30, 2020
Merged

New request format for The Media Grid Bid Adapter #5541

merged 21 commits into from
Jul 30, 2020

Conversation

TheMediaGrid
Copy link
Contributor

@TheMediaGrid TheMediaGrid commented Jul 27, 2020 •
edited
Loading

Type of change

  • Feature
  • Code style update (formatting, local variables)

Description of change

Added ability to send request in the OpenRTB format

@TheMediaGrid
Added TheMediaGridNM Bid Adapter
94d2b3a
@TheMediaGrid
Updated required params for TheMediaGridNM Bid Adapter
3ba8fd8
@TheMediaGrid
Update TheMediGridNM Bid Adapter
b830678
@TheMediaGrid
Fix tests for TheMediaGridNM Bid Adapter
9675d02
@TheMediaGrid
Merge remote-tracking branch 'upstream/master'
65cb00f
@TheMediaGrid
Merge remote-tracking branch 'upstream/master'
f1cba4a
@TheMediaGrid
Fixes after review for TheMediaGridNM Bid Adapter
52e593c
@TheMediaGrid
Merge remote-tracking branch 'upstream/master'
7b99287
@TheMediaGrid
Add support of multi-format in TheMediaGrid Bid Adapter
83fb2b4
@TheMediaGrid
Merge remote-tracking branch 'upstream/master'
926f4d9
@TheMediaGrid
Update sync url for grid and gridNM Bid Adapters
66f2ac8
@TheMediaGrid
Merge remote-tracking branch 'upstream/master'
b2fb704
@TheMediaGrid
TheMediaGrid Bid Adapter: added keywords adUnit parameter
4fcf522
@TheMediaGrid
Merge remote-tracking branch 'upstream/master'
6906f1b
@TheMediaGrid
Update TheMediaGrid Bid Adapter to support keywords from config
bfe4f5e
@TheMediaGrid
Merge remote-tracking branch 'upstream/master'
d2c199b
@TheMediaGrid
Implement new request format for TheMediaGrid Bid Adapter
64b5b8d
@TheMediaGrid
Merge remote-tracking branch 'upstream/master'
ef493f7
@TheMediaGrid
Merge remote-tracking branch 'upstream/master'
4481d01
@TheMediaGrid
Fix jwpseg params for TheMediaGrid Bid Adapter
faa9bfb
FilipStamenkovic
FilipStamenkovic suggested changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@FilipStamenkovic FilipStamenkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix your tests, they are failing.
Also, you could add more tests to cover parts like: userIds, schain, etc.

And open PR on docs repo, in that PR add changes you made:

  • schain support
  • userIds support
  • new useNewFormat parameter

modules/gridBidAdapter.js Show resolved Hide resolved
modules/gridBidAdapter.js Show resolved Hide resolved
modules/gridBidAdapter.js Show resolved Hide resolved
modules/gridBidAdapter.js Show resolved Hide resolved
@TheMediaGrid
Copy link
Contributor Author

Done, here is pull request in the doc repo - prebid/prebid.github.io#2167

@FilipStamenkovic FilipStamenkovic merged commit 2980d69 into prebid:master Jul 30, 2020
@terrorizer1980 terrorizer1980 mentioned this pull request Mar 26, 2024
Closed
@rostomzed rostomzed mentioned this pull request Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilipStamenkovic FilipStamenkovic FilipStamenkovic requested changes

Assignees

@FilipStamenkovic FilipStamenkovic

Labels
needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheMediaGrid @FilipStamenkovic @jsnellbaker