Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check that pubads fn is defined #5557

Merged
merged 1 commit into from
Jul 30, 2020
Merged

check that pubads fn is defined #5557

merged 1 commit into from
Jul 30, 2020

Conversation

msm0504
Copy link
Contributor

@msm0504 msm0504 commented Jul 30, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

pubads function may not be defined even if googletag. Add check to ensure function is available.

@msm0504 msm0504 requested a review from jsnellbaker July 30, 2020 15:25
@jsnellbaker jsnellbaker self-assigned this Jul 30, 2020
@jsnellbaker jsnellbaker merged commit 4adba22 into master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnellbaker jsnellbaker jsnellbaker approved these changes

Assignees

@jsnellbaker jsnellbaker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msm0504 @jsnellbaker