Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue Billywig bid adapter update #5584

Merged
merged 5 commits into from
Sep 4, 2020
Merged

Blue Billywig bid adapter update #5584

merged 5 commits into from
Sep 4, 2020

Conversation

K-JBoon
Copy link
Contributor

@K-JBoon K-JBoon commented Aug 10, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Bit of a messy one, as it includes the following changes:

  • General code quality upgrade (Code style update)
  • Correctly flag returned bids as a video mediatype (Bugfix)
  • Always hit user syncs, also if we don't get bid responses (Feature)
  • Validate video params, and allow submitting them additionally on the bidder params (Feature)
  • Recognize VAST URL on bids in a few more situations (Feature)
  • Remove DigiTrust (Maintenance)

If this needs to be split into multiple PRs please let me know.

Docs PR:
prebid/prebid.github.io#2198

@K-JBoon
Copy link
Contributor Author

K-JBoon commented Aug 19, 2020

Hey @ncolletti , just wondering if you needed any additional info for the review?

@K-JBoon
Copy link
Contributor Author

K-JBoon commented Aug 24, 2020

Hi @ncolletti / @mkendall07 , would really like to get an update on the progress/any blockers here, or have it re-assigned for review.

@ncolletti
Copy link
Contributor

Sorry for the delay. These changes look good to me.

@bretg bretg merged commit 7743713 into prebid:master Sep 4, 2020
@K-JBoon
Copy link
Contributor Author

K-JBoon commented Sep 9, 2020

@ncolletti All good, thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants