Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added adapters for gjirafa and malltv #5587

Merged
merged 3 commits into from
Sep 8, 2020
Merged

added adapters for gjirafa and malltv #5587

merged 3 commits into from
Sep 8, 2020

Conversation

drilon-kastrati
Copy link
Contributor

@drilon-kastrati drilon-kastrati commented Aug 10, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

  • test parameters for validating bids
  • gjirafaBidAdapter
{
  bidder: 'gjirafa',
  params: {
    propertyId: '105227',
    placementId: '846841'
  }
}
  • malltvBidAdapter
{
  bidder: 'malltv',
  params: {
    propertyId: '105135',
    placementId: '846835'
  }
}

@bretg
Copy link
Collaborator

bretg commented Aug 13, 2020

Docs PR prebid/prebid.github.io#2200

@bretg bretg requested review from GLStephen and removed request for afewcc August 24, 2020 19:11
@bretg bretg assigned GLStephen and unassigned afewcc Aug 24, 2020
@GLStephen
Copy link
Collaborator

@codewiz14 I'm looking at this and things generally look good, but your endpoint is refusing test connections. We need 100% fill sample bid params so we can see bids to verify adapters and so that publishers can use it to verify their own builds and integrations work.

This is what I'm seeing:

Access to XMLHttpRequest at 'https://central.mall.tv/bid' from origin 'http://127.0.0.1:9999' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource.
VM378:1 POST https://central.mall.tv/bid net::ERR_FAILED

I've tried both the params here and in your doc PR and neither is returning bids.

@drilon-kastrati
Copy link
Contributor Author

Hi @GLStephen, it was configured to work only for localhost:9999, we just updated the CORS policy to allow on 127.0.01:9999 as well.
Everything should work with params in our docs for both adapters.

@GLStephen
Copy link
Collaborator

@codewiz14 the gjirafa bidder looks good, but the malltv bidder is receiving an error here:

  if (!hasValidKeys()) {
    logError(errorMessage(`Bidder ${bid.bidderCode} is missing required params. Check http://prebid.org/dev-docs/bidder-adapter-1.html for list of params.`));
    return false;
  }

The error is:

ERROR: Invalid bid from malltv. Ignoring bid: Bidder malltv is missing required params. Check http://prebid.org/dev-docs/bidder-adapter-1.html for list of params.

I suspect a required parameter may have changed in V4.

@drilon-kastrati
Copy link
Contributor Author

@GLStephen the issue was on interpret response when there is no bid, so we just updated interpretResponse to return an empty array when there is no bid.

@GLStephen
Copy link
Collaborator

@codewiz14 I missed the window for the release today, but this will be in the next release

@GLStephen GLStephen merged commit bcf7b5a into prebid:master Sep 8, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
* added adapters for gjirafa and malltv

* interpretResponse fix for empty result

* updated testing propertyId and placementId
BrightMountainMediaInc added a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants