updated userid module to stop caching the entire consent object #5641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ather just a hash of it, since all we need it for is comparison purposes.
|
the CI fail seems unrelated to this PR, it's from of |
muuki88
approved these changes
Aug 20, 2020
jsnellbaker
approved these changes
Aug 20, 2020
jsnellbaker
added
the
needs 2nd review
src/utils.js
Outdated
| // IE doesn't support imul | ||
| // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Math/imul#Polyfill | ||
| if (!Math.imul) { | ||
| Math.imul = function(opA, opB) { |
There was a problem hiding this comment.
I was under the impression that we were not allowing polyfills.
I could be wrong but I thought I read / heard that somewhere...
robertrmartinez
approved these changes
Aug 20, 2020
robertrmartinez
approved these changes
Aug 20, 2020
patmmccann
reviewed
Aug 20, 2020
| * @param seed (optional) | ||
| * @returns {string} | ||
| */ | ||
| export function simpleHash(str, seed = 0) { |
There was a problem hiding this comment.
any chancce you can call this cyrb53Hash or something describing what it is; the source you chose has many hashes.
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
…id#5641) * updated userid module to stop caching the entire consent object but rather just a hash of it, since all we need it for is comparison purposes. * IE doesn't support Math.imul, so providing a polyfill for it when necessary * use `===` to compare consent values; convert hashes to a string when returning them * add test for string response and fix @returns doc * don't use polyfills!
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
…ct (prebid#5641)" This reverts commit bd892d8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
after the discussion at the end of #5451, we agreed that we should store just a hash of the consent object rather than the entire object, since all we need it for is comparison purposes between the previous consent and the current consent for the user.
Other information
#5451 (comment)