Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cmpuishown event for tcf2 logic #5642

Merged
merged 5 commits into from
Sep 1, 2020
Merged

remove cmpuishown event for tcf2 logic #5642

merged 5 commits into from
Sep 1, 2020

Conversation

jsnellbaker
Copy link
Collaborator

Type of change

  • Other

Description of change

A follow-up from #5564 - this change removes the event logic for cmpuishown as further review determined it's not really needed for Prebid.js.

Please see this comment from the previous ticket for additional context.

@jsnellbaker jsnellbaker requested a review from harpere August 20, 2020 10:45
harpere
harpere approved these changes Aug 31, 2020
View reviewed changes
Copy link
Collaborator

@harpere harpere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker removed their assignment Aug 31, 2020
@jsnellbaker jsnellbaker added needs 2nd review Core module updates require two approvals from the core team and removed needs review question labels Aug 31, 2020
@jsnellbaker jsnellbaker requested a review from smenzer September 1, 2020 13:43
@lgtm-com
Copy link

lgtm-com bot commented Sep 1, 2020

This pull request introduces 1 alert and fixes 2 when merging d4103b1 into c4c060e - view on LGTM.com

new alerts:

  • 1 for Syntax error

fixed alerts:

  • 1 for Useless conditional
  • 1 for Unvalidated dynamic method call

smenzer
smenzer approved these changes Sep 1, 2020
View reviewed changes
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

smenzer
smenzer requested changes Sep 1, 2020
View reviewed changes
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, looks like there's a syntax error

modules/consentManagement.js Show resolved Hide resolved
@jsnellbaker jsnellbaker requested a review from smenzer September 1, 2020 14:35
@smenzer smenzer merged commit c8a6010 into master Sep 1, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
@jsnellbaker
remove cmpuishown event for tcf2 logic (prebid#5642)
547093e 
* remove cmpuishown event for tcf2 logic

* store consent on "cmpuishown" event

* reverted last consnetManagement cmpuishown commit

* combine if statements

* fix typo

Co-authored-by: Eric Harper <eharper@rubiconproject.com>
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Revert "remove cmpuishown event for tcf2 logic (prebid#5642)"
ddcc0b7 
This reverts commit 547093e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harpere harpere harpere approved these changes

@smenzer smenzer smenzer approved these changes

@mike-chowla mike-chowla Awaiting requested review from mike-chowla

Assignees

@harpere harpere

Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsnellbaker @smenzer @harpere