Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send GDPR data in analytics request #5653

Merged
merged 45 commits into from
Sep 10, 2020
Merged

Send GDPR data in analytics request #5653

merged 45 commits into from
Sep 10, 2020

Conversation

bjorn-lw
Copy link
Contributor

Type of change

  • [ x] Feature

Description of change

Forward GDPR data to our statistics service

Make it possible to pass dynamic parameters to adapter
Pass metadata from adapter
@bjorn-lw
Copy link
Contributor Author

bjorn-lw commented Sep 3, 2020

@mike-chowla Any other takers on this one since @bmwcmw seem to be swamped with other work? Thanks!

@bjorn-lw
Copy link
Contributor Author

bjorn-lw commented Sep 9, 2020

@mike-chowla @bmwcmw there has been 17 days since this PR was created. Do you have any estimate to when someone has a chance to look at this? Thanks!

Copy link
Collaborator

@bmwcmw bmwcmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmwcmw bmwcmw added LGTM and removed needs review labels Sep 10, 2020
@bmwcmw bmwcmw merged commit a2da917 into prebid:master Sep 10, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
* Livewrapped bid and analytics adapter

* Fixed some tests for browser compatibility

* Fixed some tests for browser compatibility

* Changed analytics adapter code name

* Fix double quote in debug message

* modified how gdpr is being passed

* Added support for Publisher Common ID Module

* Corrections for ttr in analytics

* ANalytics updates

* Auction start time stamp changed

* Detect recovered ad blocked requests
Make it possible to pass dynamic parameters to adapter

* Collect info on ad units receiving any valid bid

* Support for ID5
Pass metadata from adapter

* Typo in test + eids on wrong level

* Fix for Prebid 3.0

* Fix get referer

* http -> https in tests

* Native support

* Read sizes from mediatype.banner

* Revert accidental commit

* Support native data collection + minor refactorings

* Set analytics endpoint

* Support for app parameters

* Fix issue where adunits with bids were not counted on reload

* Send debug info from adapter to external debugger

* SChain support

* Send GDPR data in analytics request
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants