Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RP Bid Adapter: Send config user.id as GET and XAPI bidRequest params #5666

Merged
merged 83 commits into from
Aug 26, 2020
Merged

RP Bid Adapter: Send config user.id as GET and XAPI bidRequest params #5666

merged 83 commits into from
Aug 26, 2020

Conversation

idettman
Copy link
Contributor

@idettman idettman commented Aug 26, 2020 •
edited
Loading

RP Bid Adapter: Send config user.id as GET and XAPI bidRequest params

Type of change

  • Other

Description of change

Change to the RP Bid Adapter to read a generic setConfig user.id field, passing to Ad Engine as a query parameter "ppuid" and xapi by user.id.

  • RP Bid Adapter will read from config user.id
  • RP Bid Adapter will pass to AE the value using "ppuid" to GET
  • RP Bid Adapter will pass to AE the value user.idto XAPI

nakamoto and others added 30 commits February 16, 2019 21:30
Add microadBidAdapter
8d635ff
Remove unnecessary encodeURIComponent from microadBidAdapter
3055b90
Submit Advangelists Prebid Adapter
67fb91b
Submit Advangelists Prebid Adapter 1.1
3ebb916
Correct procudtion endpoint for prebid
4f5c451
Merge branch 'microad-bid-adapter' of git://github.com/strong-zero/Pr…
2dc6d1d 
…ebid.js into master-rubicon-clean
Merge remote-tracking branch 'origin/master' into master-rubicon-clean
fa3e081 
# Conflicts:
#	modules/advangelistsBidAdapter.js
#	test/spec/modules/advangelistsBidAdapter_spec.js
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
600a46e 
…ter-remote-updated
Merge branch 'master' of https://github.com/prebid/Prebid.js
7f578b3
Merge branch 'master' of https://github.com/prebid/Prebid.js
176a312
Merge branch 'master' of https://github.com/prebid/Prebid.js
9abf89c
Merge remote-tracking branch 'upstream/master'
6ce04ab
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
415e2f6 
…ter-origin
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
61fb82c 
…ter-origin-rp
analytics update with wrapper name
3cc4c67
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
cd81e02 
…ter-origin-rp
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
e2b4e04 
…ter-origin-rp
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
53b5970 
…ter-origin-rp
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
5c00ed5 
…ter-origin-rp
reverted error merge
28848ad
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
ab635ee 
…ter-origin-rp
Merge branch 'master' of https://github.com/prebid/Prebid.js into mas…
93308f5 
…ter-origin-rp
Merge branch 'master' of https://github.com/prebid/Prebid.js
1cfd52d
Merge branch 'master' of https://github.com/prebid/Prebid.js
d619807
Merge branch 'master' of https://github.com/prebid/Prebid.js
9893f0f
Merge remote-tracking branch 'upstream/master'
986a251
Merge branch 'master' of https://github.com/prebid/Prebid.js into ori…
2cae7c0 
…gin-master
Merge branch 'master' of https://github.com/prebid/Prebid.js
d7fd252
Merge branch 'master' of https://github.com/prebid/Prebid.js
c7c01ba
Merge branch 'master' of https://github.com/prebid/Prebid.js
24a28aa
idettman added 13 commits May 20, 2020 12:41
Merge branch 'master' of https://github.com/prebid/Prebid.js
7215461
Merge remote-tracking branch 'origin/master'
258c555
Merge remote-tracking branch 'remotes/remote/master'
a921ac9
Merge branch 'master' of https://github.com/prebid/Prebid.js
90975d1
Merge branch 'master' of https://github.com/prebid/Prebid.js
aac67fa
Merge branch 'master' of https://github.com/prebid/Prebid.js
585993c
Merge branch 'master' of https://github.com/prebid/Prebid.js
20f5825
Merge branch 'master' of https://github.com/prebid/Prebid.js
8ce42f0
Merge branch 'master' of https://github.com/prebid/Prebid.js
253b8bb
Merge branch 'master' of https://github.com/prebid/Prebid.js
dc7fba5
Merge branch 'master' of https://github.com/prebid/Prebid.js
b93665b
Merge branch 'master' of https://github.com/prebid/Prebid.js
6e60389
pass config user.id to get and xapi requests
b995ce9
robertrmartinez
robertrmartinez approved these changes Aug 26, 2020
View reviewed changes
Copy link
Collaborator

@robertrmartinez robertrmartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertrmartinez robertrmartinez merged commit a234c87 into prebid:master Aug 26, 2020
@idettman idettman changed the title RP Bid Adapter read user.id RP Bid Adapter Read user.id Aug 26, 2020
@idettman idettman changed the title RP Bid Adapter Read user.id RP Bid Adapter Read user.id Aug 26, 2020
@idettman idettman changed the title RP Bid Adapter Read user.id RP Bid Adapter: Read user.id Aug 26, 2020
@idettman idettman changed the title RP Bid Adapter: Read user.id RP Bid Adapter: Read config user.id Aug 26, 2020
@idettman idettman changed the title RP Bid Adapter: Read config user.id RP Bid Adapter: Send config user.id as GET and XAPI bidRequest params Aug 26, 2020
@patmmccann
Copy link
Collaborator

Does this need docs @robertrmartinez @idettman . It appears RP is now accepting publisher provided user id, how do I transmit that?

BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
@msm0504
RP Bid Adapter read user.id (prebid#5666)
bf33cbb 
* Add microadBidAdapter

* Remove unnecessary encodeURIComponent from microadBidAdapter

* Submit Advangelists Prebid Adapter

* Submit Advangelists Prebid Adapter 1.1

* Correct procudtion endpoint for prebid

* analytics update with wrapper name

* reverted error merge

* update changed default value of netRevenue to true

* Re-add rubicon analytics without deprecated getTopWindowUrl util

* Cache referrer on auction_init instead of bid_requested

* merged remote master changes

* pass config user.id to get and xapi requests

Co-authored-by: nakamoto <nakamoto_tatsuya@microad.co.jp>
Co-authored-by: Chandra Prakash <chandra.prakash@advangelists.com>
Co-authored-by: Eric Harper <eharper@rubiconproject.com>
Co-authored-by: TJ Eastmond <teastmond@la-wlandaverde-mac.local>
Co-authored-by: Mark Monday <mmonday@rubiconproject.com>
Co-authored-by: msm0504 <51493331+msm0504@users.noreply.github.com>
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Revert "RP Bid Adapter read user.id (prebid#5666)"
8ee4856 
This reverts commit bf33cbb.
@robertrmartinez robertrmartinez deleted the add-rpadapter-support-config-userid branch July 5, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertrmartinez robertrmartinez robertrmartinez approved these changes

@bretg bretg Awaiting requested review from bretg

@harpere harpere Awaiting requested review from harpere

Assignees

@robertrmartinez robertrmartinez

Labels
needs docs needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@idettman @patmmccann @robertrmartinez @msm0504