Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pub-X Bid adapter #5676

Merged
merged 3 commits into from
Sep 9, 2020
Merged

Add Pub-X Bid adapter #5676

merged 3 commits into from
Sep 9, 2020

Conversation

Pub-X
Copy link
Contributor

@Pub-X Pub-X commented Aug 30, 2020

Type of change

  • New bidder adapter

Description of change

Adding Pub-X Bid Adapter

  • test parameters for validating bids
{
  bidder: 'pubx',
  params: {
    sid: 'eDMR'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
    x@pub-x.io
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Copy link
Collaborator

@GLStephen GLStephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, just take a look at my one comment. Just want to make sure that's as you intended.

modules/pubxBidAdapter.js Outdated Show resolved Hide resolved
@GLStephen GLStephen merged commit 85cf495 into prebid:master Sep 9, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
* add Pub-X Bid Adapter

* add Pub-X Bid Adapter

* remove alias
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants