GDPR Enforcement - Bugfix #5686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
smenzer
requested changes
Sep 2, 2020
modules/gdprEnforcement.js
Outdated
| } | ||
| return gvlId; | ||
| return gvlid; |
There was a problem hiding this comment.
could this also be shortened to just one-line?
return adapterManager.getAnalyticsAdapter(code) && adapterManager.getAnalyticsAdapter(code).gvlid || null;
There was a problem hiding this comment.
Made the change. Was reluctant earlier because if the condition before && returns false, the function will return undefined and not null. Kind of a minor inconsistency, but I don't think that'll play a big role.
smenzer
added
the
needs 2nd review
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
* consolicate getGVLID function into a single function * pass correct arguments to gvlid getter functions * have one master getGvlid getter function to rule other gvlId getter functions * restore to file state on master branch * remove unnecessary example * remove unnecessary reference from internal object * works on comments and change getgvlidForAnalyticds Adapter to a one liner
BrightMountainMediaInc
pushed a commit
to BrightMountainMediaInc/Prebid.js
that referenced
this pull request
Sep 14, 2020
This reverts commit 52ce9af.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Resolves #5615
This PR implements the alternate approach discussed here - #5643
This PR makes an assumption: