Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor validation update to consentManagement.js #5701

Merged
merged 1 commit into from
Sep 8, 2020
Merged

minor validation update to consentManagement.js #5701

merged 1 commit into from
Sep 8, 2020

Conversation

harpere
Copy link
Collaborator

@harpere harpere commented Sep 4, 2020

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Made cmpConsentObject validation consistent.

smenzer
smenzer approved these changes Sep 7, 2020
View reviewed changes
Copy link
Collaborator

@smenzer smenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smenzer smenzer added the needs 2nd review Core module updates require two approvals from the core team label Sep 7, 2020
@robertrmartinez robertrmartinez self-requested a review September 8, 2020 15:38
@robertrmartinez robertrmartinez merged commit c3c04f5 into master Sep 8, 2020
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
@harpere
minor validation update to consentManagement.js (prebid#5701)
91654c0 
Co-authored-by: Eric Harper <eharper@rubiconproject.com>
BrightMountainMediaInc pushed a commit to BrightMountainMediaInc/Prebid.js that referenced this pull request Sep 14, 2020
Revert "minor validation update to consentManagement.js (prebid#5701)"
0aca6ec 
This reverts commit 91654c0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertrmartinez robertrmartinez robertrmartinez approved these changes

@smenzer smenzer smenzer approved these changes

Assignees

@robertrmartinez robertrmartinez

Labels
needs 2nd review Core module updates require two approvals from the core team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harpere @smenzer @robertrmartinez