Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeta-Prebid #5813

Merged
merged 17 commits into from
Nov 12, 2020
Merged

Zeta-Prebid #5813

merged 17 commits into from
Nov 12, 2020

Conversation

mwehr-zeta
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

A bidder adapter for Zeta Global

  • test parameters for validating bids
{
  mediaTypes: {
    banner: {
      sizes: [[300, 250]],
    }
  },
  bids: [{
    bidder: 'Zeta Global',
    bidId: 12345,
    params: {
      placement: 12345,
      user: {
        uid: 12345,
        buyeruid: 12345
      },
      ip: '111.222.33.44',
      test: 1
    }
  }]
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@smenzer
Copy link
Collaborator

smenzer commented Oct 1, 2020

please remove the package-lock.json file from this PR. thanks!

@mwehr-zeta
Copy link
Contributor Author

mwehr-zeta commented Oct 8, 2020

Comment addressed and docs submitted: prebid/prebid.github.io#2409

modules/zetaBidAdapter.js Outdated Show resolved Hide resolved
modules/zetaBidAdapter.md Outdated Show resolved Hide resolved
@mwehr-zeta
Copy link
Contributor Author

Is there an update on this? All comments should be addressed.

@GLStephen
Copy link
Collaborator

@mwehr-zeta I still see one final issue, I'm just not getting any test bids back and all of the XMLHttpRequests to your endpoint are failing.

image

@ilhelka
Copy link

ilhelka commented Oct 27, 2020

Hi @GLStephen, thanks for the heads up. Responding to confirm receipt and @mwehr-zeta is addressing the issue. We should have an update soon. Cheers, Ilham E (Zeta DSP PM)

@mwehr-zeta
Copy link
Contributor Author

We will need to complete a deployment of our bidders to address the header issue.

@GLStephen
Copy link
Collaborator

@mwehr-zeta please ping me when it's done and I'll recheck

@mwehr-zeta
Copy link
Contributor Author

@GLStephen It should be good to go

@GLStephen GLStephen merged commit 17beca2 into prebid:master Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants