Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prebid Server Bid Adapter: Expose errors and server response times always #5866

Merged
merged 5 commits into from
Nov 17, 2020
Merged

Prebid Server Bid Adapter: Expose errors and server response times always #5866

merged 5 commits into from
Nov 17, 2020

Conversation

robertrmartinez
Copy link
Collaborator

Type of change

  • Other

Description of change

PBSBidAdapter will now:

  • expose the error objects for each bidder onto the associated bidders bidderRequest if present.
  • expose server response time for each bidder on their bidderRequest object regardless if bid was successful

Rubicon Analytics Adapter will use these fields accordingly.

@jsnellbaker jsnellbaker self-requested a review October 22, 2020 14:57
jsnellbaker
jsnellbaker approved these changes Oct 22, 2020
View reviewed changes
Copy link
Collaborator

@jsnellbaker jsnellbaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnellbaker jsnellbaker added the needs 2nd review Core module updates require two approvals from the core team label Oct 22, 2020
@jsnellbaker jsnellbaker assigned msm0504 and unassigned jsnellbaker Oct 22, 2020
msm0504
msm0504 suggested changes Oct 27, 2020
View reviewed changes
modules/prebidServerBidAdapter/index.js Outdated Show resolved Hide resolved
@robertrmartinez
Copy link
Collaborator Author

@msm0504

I made the suggested change, it look ok?

@lgtm-com
Copy link

lgtm-com bot commented Nov 13, 2020

This pull request introduces 2 alerts when merging 06bb14e into 09468bf - view on LGTM.com

new alerts:

  • 2 for Expression has no effect

@msm0504 msm0504 added LGTM and removed needs 2nd review Core module updates require two approvals from the core team labels Nov 17, 2020
@msm0504 msm0504 merged commit 96989ca into master Nov 17, 2020
@msm0504 msm0504 deleted the PBS_Bidder_ResponseTimes branch November 17, 2020 14:29
stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
@robertrmartinez @stsepelin
Prebid Server Bid Adapter: Expose errors and server response times al…
4a98d01 
…ways (prebid#5866)

* Expose pbs reported errors
Expose serverLatencyMillis always

* clean up logic for other weird edge case

* review comment for make function

* not sure how parenthesis got there
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msm0504 msm0504 msm0504 approved these changes

@jsnellbaker jsnellbaker jsnellbaker approved these changes

Assignees

@msm0504 msm0504

Labels
LGTM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertrmartinez @jsnellbaker @msm0504