Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get dynamic ttl from the server response #5896

Merged
merged 8 commits into from
Nov 4, 2020
Merged

get dynamic ttl from the server response #5896

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ce1592f
Change ironsource to be lower case all over code
liranbaruch Aug 21, 2020
5259274
Merge branch 'master' of https://github.com/prebid/Prebid.js
liranbaruch Aug 26, 2020
68077a8
Merge branch 'master' of https://github.com/prebid/Prebid.js
liranbaruch Aug 30, 2020
a3e1129
Merge branch 'master' of https://github.com/prebid/Prebid.js
liranbaruch Oct 7, 2020
25e0e1f
Add test mode to the IronSource bidder
liranbaruch Oct 7, 2020
8237abb
Merge branch 'master' of https://github.com/prebid/Prebid.js
liranbaruch Oct 25, 2020
5fecd2f
get dynamic ttl from the server response
liranbaruch Oct 25, 2020
dcbe129
Merge branch 'master' of https://github.com/prebid/Prebid.js
liranbaruch Nov 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/ironsourceBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export const spec = {
creativeId: body.requestId,
currency: body.currency,
netRevenue: body.netRevenue,
ttl: TTL,
ttl: body.ttl || TTL,
vastXml: body.vastXml,
mediaType: VIDEO
};
Expand Down
2 changes: 1 addition & 1 deletion test/spec/modules/ironsourceBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ describe('ironsourceAdapter', function () {
mediaType: VIDEO
}
];
const result = spec.interpretResponse({ body: [response] });
const result = spec.interpretResponse({ body: response });
expect(Object.keys(result[0])).to.have.members(Object.keys(expectedResponse[0]));
});
})
Expand Down