Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init bizzclick prebid.js adapter #5914

Merged
merged 7 commits into from
Nov 19, 2020
Merged

init bizzclick prebid.js adapter #5914

merged 7 commits into from
Nov 19, 2020

Conversation

BizzClick
Copy link
Contributor

@BizzClick BizzClick commented Oct 30, 2020

Type of change

  • [ x] New bidder adapter

Description of change

  • test parameters for validating bids
{
  bidder: 'bizzclick',
  params: {
    placementId: 'hash',
    accountId: 'bizzclickTest'
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@BizzClick
Copy link
Contributor Author

Hey @musikele ! Do you have chance to review my Adpater ?

Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there. Sorry for being late. It seems to me that the code coverage is under 80%, that is the code coverage we require for adapters.

To test this,

$ npx gulp test-coverage 

$ npx gulp view-coverage

Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some notes, feel free to go into them.

modules/bizzclickBidAdapter.js Outdated Show resolved Hide resolved
modules/bizzclickBidAdapter.js Outdated Show resolved Hide resolved
@BizzClick
Copy link
Contributor Author

Hello @musikele ! Thanks for you review! I have updated my adapter could you please check it?

Copy link
Contributor

@musikele musikele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@musikele
Copy link
Contributor

musikele commented Nov 16, 2020

@devBizzclick Before final merge, we need to rebase against current master, because there was an issue with a test that prevented the Continuous Integration to test without errors.
Run these commands:

git pull --rebase origin master 
git push --force 

This should fix the Continuous Integration.

@BizzClick
Copy link
Contributor Author

@musikele I have made rebase to master but I still have problems with CI

@musikele
Copy link
Contributor

@BizzClick this time the problem is less serious. File BizzClickBidAdapter_spec.js is not properly formatted. You may either fix all linting errors manually or run npx gulp lint and commit the modified files. Let me know when you're done.

@BizzClick
Copy link
Contributor Author

Hello, @musikele ! I would not like to bother you, but I still have CI build error after fix linting. Could you please help me resolve it?

@musikele
Copy link
Contributor

@BizzClick the circleci only needed another spin. Going to merge now.

@musikele musikele merged commit 6fea844 into prebid:master Nov 19, 2020
@bretg
Copy link
Collaborator

bretg commented Nov 19, 2020

docs PR prebid/prebid.github.io#2511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants