-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init bizzclick prebid.js adapter #5914
Conversation
Hey @musikele ! Do you have chance to review my Adpater ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there. Sorry for being late. It seems to me that the code coverage is under 80%, that is the code coverage we require for adapters.
To test this,
$ npx gulp test-coverage
$ npx gulp view-coverage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some notes, feel free to go into them.
Hello @musikele ! Thanks for you review! I have updated my adapter could you please check it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@devBizzclick Before final merge, we need to rebase against current master, because there was an issue with a test that prevented the Continuous Integration to test without errors.
This should fix the Continuous Integration. |
@musikele I have made rebase to master but I still have problems with CI |
@BizzClick this time the problem is less serious. File BizzClickBidAdapter_spec.js is not properly formatted. You may either fix all linting errors manually or run |
Hello, @musikele ! I would not like to bother you, but I still have CI build error after fix linting. Could you please help me resolve it? |
@BizzClick the circleci only needed another spin. Going to merge now. |
docs PR prebid/prebid.github.io#2511 |
Type of change
Description of change
Be sure to test the integration with your adserver using the Hello World sample page.
support@bizzclick.com
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information