update quantcastBidAdapter to make user sync flag non-constant #5949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mckurt
force-pushed
the
mcankurt/bug_fix
branch
from
04d4cd7
to
8f0dd51
Compare
robertrmartinez
approved these changes
Nov 13, 2020
|
@robertrmartinez Thanks for the review. When can we merge this PR? |
stsepelin
pushed a commit
to cointraffic/Prebid.js
that referenced
this pull request
May 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
This PR updates quantcastBidAdapter to move
hasUserSyncedflag out of the spec object and make it non-constant. Otherwise, the adapter throws an error with the following message, when the flag's value is changed in strict mode: "Uncaught TypeError: "hasUserSynced" is read-only"