Fix iframe __tcfapi arguments #6058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnellbaker
approved these changes
Dec 1, 2020
jsnellbaker
added
needs 2nd review
msm0504
approved these changes
Dec 6, 2020
msm0504
added
LGTM
and removed
needs 2nd review
GLStephen
added a commit
to PubWise/Prebid.js
that referenced
this pull request
Feb 14, 2021
* GumGum: sets mediaType of bidRequest depending on product id (#6066)
* adds support for zone and pubId params
* adds support for iriscat field
* sets mediatype depending on product id
* Update doc for mediaType needed for video products
* pubgenius: remove video cache key to be future-proof (#6081)
* fix pubgenius unit test (#6090)
* 6012: Fix for passing US Privacy string in buildVideoUrl and buildAdpodVideoUrl (#6075)
* added support for pubcommon, digitrust, id5id
* added support for IdentityLink
* changed the source for id5
* added unit test cases
* changed source param for identityLink
* pass USP consent string in dfpVideoUrl and dfpAdpodVideoUrl
* added test cases
* fix prebid server playerwidth and height (#6073)
Co-authored-by: Reinout Stevens <reinout@crazygames.com>
* Fix iframe __tcfapi arguments (#6058)
* Fix __tcfapi declaration in iframe
* Add tests for cmp declaration in iframe
* Feature/vmuid connectid rebrand (#6045)
* Key name change from vmuid to vmcid
* Change the userId key name to vmconnectid
* Support new key in response payload + remain backward compatible.
Co-authored-by: slimkrazy <sam@slimkrazy.com>
* Beachfront adapter: Add banner tagid param (#6086)
* add tagid to banner request
* bump version
* update test case
* run tests
Co-authored-by: John Salis <johnsalis@beachfrontmedia.com>
* changed events endpoint (#6088)
* [Triplelift] Fix FPD key-value pairs logic (#6065)
* follow spec to parse fpd
* ad unit support stub
* adunit method
* ad unit etc
* typo
* fix test
* typo
* change to const
* Add new adapter - adWMGBidAdapter (#6070)
* Add adWMG Bid Adapter
* Fix unit tests
Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us>
* Add PubWise Bid Adapter (#6044)
* updates for first cut at bidder
* fix up height and width
* adds test spec
* remove hello_world from commit'
* updates to support native and fix issues found in initial review
* fix handling of new node in response for native vs banner
* updates to handle OpenRTB base
* updates to support RTB style calls
* updates to get back to parity
* updates to testing
* updates to test media type handling
* updates to handling testing
* updates to testing
* remove report file
* updates to fix up unit/spec tests
* updates to fix up unit/spec tests
* updates to fix up unit/spec tests
* updates to handling of gdpr
* Delete hello_world.html
* remove hellow-world-sample
* Pubwise 481 (#7)
* updates to support PubWise bid adapter, test cases and documentation
* updates to fix param tes
* Pubwise 481 (#8)
* fixes for unit testing
* remove unused variables and params
* Updates to Remove Unused Vars (#9)
* remove unused vars
* updates to fix up used and unsused params
* updates to fix up used and unsused params (#10)
* updates to fix up used and unsused params
* updates to remove usersync and add gvlid
* Pubwise 481 (#11)
* updates to remove usersync, add https, and add gvlid
* Update pubwiseBidAdapter.js
* updates to remove json, to remove options hit
* Vdoai adapter update - Added video mediaType support (#5970)
* added video mediatype support to vdoai adapter
* added unit test
* Price Floors update to include modelTimestamp displaying when the floors file was produced (#6061)
Rubicon Anaytics Update to pass modelTimestamp if exists
* Adagio Bid Adapter: hotfix - detect support for intersectionObserver (#6095)
* Detect support for intersectionObserver
* Fix IE11
* Add special params for non standard integration
* Stronger IntersectionObserver detection
* Fix test and add new params to .md file
* Adt new alias (#6004)
* Add new alias
* Add new aliases and fix endpoints
* lint
* Fix tests
* Prebid 4.9.0 Release
* Increment pre version
* Add Release Drafter Instructions to PR_REVIEW.md (#6085)
* Add Release Drafter Instructions to PR_REVIEW.md
* Add Prettier Formatting
Makes keywords more distinct.
Co-authored-by: Scott Menzer <scott@id5.io>
Co-authored-by: Scott Menzer <scott@id5.io>
* fix typo in PREVENT_WRITING_ON_MAIN_DOCUMENT (#6102)
* appnexusBidAdapter - update segment param logic (#6103)
* Change craftBidAdapter request URL (#6096)
* Add Kubient bid adapter, Remove alias from Fidelity bid adapter. (#6084)
* Add New Kubient Bid Adapter
* Add New Kubient Bid Adapter
* Fidelity Bid Adapter Update. Less 'Kubient' Alias
* New Kubient Bid Adapter. Errors fix.
* [Sharethrough] Add Support for badv/bcat and Identity Link User ID (#6100)
* Add support for badv and bcat
[#175358412]
Co-authored-by: Michael Duran <mduran@sharethrough.com>
* Add support for Identity Link
[#175688307]
Co-authored-by: Michael Duran <mduran@sharethrough.com>
Co-authored-by: Michael Duran <mduran@sharethrough.com>
* Sovrn: Pass the imp.ext.deals field (#6098)
* EX-2549 Pass segments parameter as imp.ext.dealids array
* EX-2549 Address Jon's feedback
* EX-2549 Reworked the solution
* EX-2549 Blackbird compatibility
* EX-2549 Address Jon's comments
* EX-2549 Addressed upstream PR comments
* oneVideo Adapter - Dynamic TTL support (SAPR-15473) (#6108)
* ttl incoming value or default 300
* ttl validation 0-3600
* Fix to oneVideo tests
* added ttl unit tests
* updated md file
* update minor version 3.0.5
* Updated unit test for minor version check
* remove x from liveIntentIdSystem_spec.js
* md conflict fix
* fix missing comma in md file
* update minor version 3.0.5
* remove x from liveIntentIdSystem_spec.js
* update md file
* added ttl to md file
* ttl incoming value or default 300
* ttl validation 0-3600
* Fix to oneVideo tests
* added ttl unit tests
* updated md file
* update minor version 3.0.5
* Updated unit test for minor version check
* remove x from liveIntentIdSystem_spec.js
* md conflict fix
* update minor version 3.0.5
* remove x from liveIntentIdSystem_spec.js
* update md file
* added ttl to md file
* cleanup
* Add Gulp Review-Start Task (#6067)
* add review-start gulp command
* remove watch, unecessary for reviews
* add instructions to reviewer file for new command
* Updates to add back watch
* updates to had reviewer hub page
* Update PR_REVIEW.md
* appnexusBidAdapter - add support for test flag (#6119)
* feat(sublimeBidAdapter): updating sublimeBidAdapter module (#6113)
- using a simple-request for the POST bid request
- renaming our internal ver pixel param to pbav
* oneTag Bid Adapter: bidRequest object adjustments (#6105)
* Propagates server data directly without members picking, extracts userIds from the the validBidRequest object
* Picks netRevenue value from received bid, defaulting to false
Co-authored-by: francesco <f.orazini@onetag.com>
* a/b testing framework baked in to the ID5 user id module (#6076)
* Add Zemanta adapter (#6039)
* vdoai Bid Adapter: added multisize array in bid requests (#6101)
* added multisize array in vdoai bid requests
* fixing a bug dimentions
* Sovrn Bid Adapter: Change TTL field (#6083)
* Change TTL field for SovrnBidAdapter
* Fix unit tests
* Fix codestyle in unit tests
* Fix tests
* Fix tests
* Removed ext field from some tests
* Trying to make ext field optional
* Codestyle changes
* Change bidder url for Qwarry adapter (#6128)
* qwarry bid adapter
* formatting fixes
* fix tests for qwarry
* qwarry bid adapter
* add header for qwarry bid adapter
* bid requests fix
* fix tests
* response fix
* fix tests for Qwarry bid adapter
* add pos parameter to qwarry bid adapter
* qwarryBidAdapter onBidWon hotfix
* Change bidder endpoint url for Qwarry adapter
Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com>
Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com>
* Add Automatic Release Drafter Functionality to Prebid Repository (#5954)
* Create release-drafter.yml
* Create release-drafter.yml
* Update release-drafter.yml
* Update release-drafter.yml
* Price Floors update to include modelWeight in the bid request to give additional context for Analytics adapters that the Floors Module is schema mode 2, and the floors module picks a model prior to an auction based on the modelWeight supplied in the floors module definition (#6126)
Rubicon Analytics Update to pass modelWeight if exists
* Prebid 4.20.0 Release
* Increment pre version
* GumGum: makes slot and invideo products avail with pubId (#6107)
* Add support for tagId parameter (#6133)
* Add support for tagId parameter
* Update maintainer email to an alias
* Inmar bidder adapter: Make adNetId an optional paramater (#6136)
* Update Inmar bidder adapter
* Set withCredentials to true
* Remove inmarId from Inmar bidder adapter
* Remove withCredentials because it defaults to true
* Added VOX Bidder Adapter (#6030)
* Added voxBidAdapter.js to get a bid from partners.hybrid.ai
* Added placements ids for testing
Co-authored-by: s-shevtsov <s.shevtsov@targetix.net>
* added Engageya bid adapter (#6109)
* added Engageya bid adapter
* moved test function from adapter to spec
* remove function import
* PAGE_URL should be String
* Fix userIds format for TheMediaGrid Bid Adapter (#6142)
* Added TheMediaGridNM Bid Adapter
* Updated required params for TheMediaGridNM Bid Adapter
* Update TheMediGridNM Bid Adapter
* Fix tests for TheMediaGridNM Bid Adapter
* Fixes after review for TheMediaGridNM Bid Adapter
* Add support of multi-format in TheMediaGrid Bid Adapter
* Update sync url for grid and gridNM Bid Adapters
* TheMediaGrid Bid Adapter: added keywords adUnit parameter
* Update TheMediaGrid Bid Adapter to support keywords from config
* Implement new request format for TheMediaGrid Bid Adapter
* Fix jwpseg params for TheMediaGrid Bid Adapter
* Update unit tests for The Media Grid Bid Adapter
* Fix typo in TheMediaGrid Bid Adapter
* Added test for jwTargeting in TheMediaGrid Bid Adapter
* The new request format was made by default in TheMediaGrid Bid Adapter
* Update userId format in ad request for TheMediaGrid Bid Adapter
* Added bidFloor parameter for TheMediaGrid Bid Adapter
* Fix for review TheMediaGrid Bid Adapter
* Support floorModule in TheMediaGrid Bid Adapter
* Fix empty bidfloor for TheMediaGrid Bid Adapter
* Some change to restart autotests
* Fix userIds format for TheMediaGrid Bid Adapter
* Remove digitrust userId from TheMediaGrid Bid Adapter
* ID Library feat: turn off fullscan by default (#6140)
* chore: lint HTML example page
* chore: add space to logging statement for clarity
* chore: update package lock
* feat: turn off fullscan by default
* chore: format the HTML for readibility
* chore: fix test
* Revert "chore: update package lock"
This reverts commit 4faf19489677de3c278b625535f4ba01877ccacb.
* update release process for notes on release drafter checks (#6137)
* update release process for notes on release drafter checks
* update section titles
* Sspbc Bid Adapter: multiple updates (#6118)
* add sspbc adapter
* tests for sspbc adapter
* sspBC adapter v4.5: set correct creativeId, add adomain to bid.meta, set test mode in adexchange, read site SN from bid response
* sspBC adapter v4.5: set meta.advertiserDomains, update test to expect bid.meta
* sspBC Adapter: add ajax tests (test ad with & without gdpr)
* sspBC Adapter: remove ajax tests
* Update adapter to v4.6
Update adapter to v4.6
- add notification endpoint
- send bidWon and onTimeout notifications
- send CMP version to user sync endpoint
* Remove console logs for notification events
* Change payload data in onTimeout event
* Update tests for sspBC adapter
Update tests for sspBC adapter:
- add onBidWon test
- add onTimeout test
- alter getUserSyncs test
* Update sspBC adapter to v4.7; enable oneCodeId mode; change module name to ensure combatibility with prebid.org downloader
* sspBc adapter: Bug fixes in v4.7 - change notification format, fix oneCode detection data, convert slot number to int
Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>
* oneVideo Adapter - Content Object support (SAPR-15477) (#6110)
* updated object,str,num validations using pbjs utils
* validation if statements for content object
* validation if statements for content object
* updated contetn object validations using utils
* refractoring clean if statement
* fixing typos
* added todos
* added category string & data object validations
* fixed esling ENDPOINT issue
* updated content obj unit tests
* fixed cat & data validation
* fixed producer as object
* revert .includes() to .indexof() for IE
* reduced content obj params accoriding to ad-server support
* fixed typeOf typo
* fixed episode to Number
* gitignore
* restore gitignore
* removed unsupported params from md file
* reverted package & pagkage-lock
* fixed incorrect episdoe from str to num
* GumGum: adds support for new field - irisid (#6129)
* adds support for new field - irisid
* remove package-lock.json
* revert psckage-lock.json to source
* AdmixerBidAdapter - add alias , add adapter config (#6120)
* add alias "adblender", custom endpoint
* remove houseofpubs
* add config example
* update email
* adblender.md fix naming
* Zeta updates - Pass additional data through adapter (#6134)
* Submit Zeta Adapter to Prebid
* comments addressed
* demo changes
* additional polishing
* additional polishing
* Update hello_world.html
* remove extraneous changes to hello_world.html
* no, really this time
* additional polishing
* add unit test
* Update Zeta bid adapter to pass more data
* Yieldlab - Update Adsize Handling (#6123)
* FreeWheel add support for campaignId, bannerId, and dealId (#6144)
* Refactored dealId code to modularize obtaining ids from the Impression node
* Added support for obtaining bannerId and campaignId
* Added logic to prioritize Impression nodes with a rootViewKey
* Added test cases to cover new logic for obtaining dealId, bannerId, and campaignId
* IronSourceBidAdapter: Change logic of detect pageURL (#6147)
* Change ironsource to be lower case all over code
* Add test mode to the IronSource bidder
* get dynamic ttl from the server response
* Change page_url logic
* LiveConnect, lighter-weight module (#6016)
* NT. Trying out how webpack plays with env vars
* NT. Test run before merge
* NT. POC kinda ok for me now
* NT. Updated the lc version to released one.
* NT. Reverting test data. Ready for PR
* NT. Fixing linting.
* NT. Fixing the email hash scenario.
* Remove hard string req, just convert instead (#6160)
* Add video skippability params (#6161)
* pubx bid adapter: add getUserSyncs (#6164)
* Eplanning: new prioritization metric for adunit sizes (#6139)
* Eplanning: new optional parameter is added
* Eplanning: new prioritization metric for adunit sizes
* Eplanning: desktop prioritization test for adunit sizes
* Prebid 4.21.0 Release
* Increment pre version
* changed vdo.ai bidder code to vdoai (#6135)
* appnexusBidAdapter - add support for netId userID (#6114)
* Update ucfunnelBidAdapter (#6157)
* support TCFv2.0
* support coppa
* support Publisher Domain
* support meta.mediaType and meta.advertiserDomains
* test parameters for validating bids
Co-authored-by: root <root@ubuntu.members.linode.com>
Co-authored-by: Ryan Chou <ryanchou0210@gmail.com>
Co-authored-by: jack.hsieh <moonnight8520@gmail.com>
* DfpAdServerVideo: Pass GDPR Consent Data (#6143)
* pass GDPR consent data in dfpVideoUrl and dfpAdpodVideoUrl
* Send gdpr param as a number
Co-authored-by: Mark Monday <mmonday@rubiconproject.com>
* TE Medya Prebid Adapter (#6168)
* TE Medya Prebid Adapter
Hello @aleksatr ,
We have completed the prebid adapter development for our TE Medya advertisement panel. We ran the tests and checked that it works. I request your review.
Best.
* Create temedyaBidAdapter_spec.js
* Update temedyaBidAdapter_spec.js
* Update temedyaBidAdapter_spec.js
* Update temedyaBidAdapter_spec.js
* store privacy object from id5 response in local storage for interoperability with our api (#6169)
* CAP-2116 updated the placementId property to tagId (#6171)
Co-authored-by: Rajkumar Natarajan <rajkumar.natarajan@synacor.com>
* Rise adapter (#6165)
* add Rise adapter
* fixes
* change param isOrg to org
* Rise adapter
* change email for rise
* fix circle failed
* bump
* bump
* bump
* remove space
* new optional params (#6148)
* Add the root domain check method as a util method added for use mod… (#6124)
* Add the root domain check method as a global method added for use modules
* Add a date suffix to keep the test cookie random
* Per review, moved the findRootDomain method to utils out of the userId modules
* More the domain method back the user module but attach it to the submodule so that userId modules can have access to it
* Remove the storageManager as it is no longer used in utils
* fix includes and find references in various files (#6183)
* Fix typo in mediaforce bid adapter (#6181)
* add mediaforce bid adapter
* make use of unused variable language
* Added native support for Mediaforce Bid Adapter
* Fix test endpoint url for Mediaforce Bid Adapter
* cleanup
* Added the ability to send multiple bids in one ad request for mediaforce bid adapter
* Fixes after review for mediaforce bid adapter
* Fix typo in mediaforce bid adapter
Co-authored-by: ksanksana <little.grey.goblin@gmail.com>
* Prebid JS Native Phase 2 update: (#5411)
* Prebid JS Native Phase 2 update:
1) Key Suppression for Native keys with sendTargetingKeys set to false at nativeParams.sendTargetingKeys or within asset i.e. nativeParams.image.sendTargetingKeys. Logic as follows:
- If nativeParams.sendTargetingKeys set to false but asset has sendTargetingKeys set to true then add the KV
- Else if nativeParams.sendTargetingKeys is set to true and asset does not have sendTargetingKeys defined or it is set to true then add KV
- Else if nativeParams.sendTargetingKeys is not defined and asset does not have sendTargetingKeys defined or it is set
to true then add KV
If no conditions met then key is suppressed
2) Adds rendererUrl or adTemplate to the bid object for easy retrieval if assets requested from creative
3) Adds new logic to receiveMessage function in secureCreatives.js to answer data.action of 'allAssetRequest' with all available assets on the bid that have a value
4) Adds new native keys to constants.json
* Update to simplify send asset logic
* Fixed asset location typo
* Update to include message listener for native resize and update adObject for auction to include creative height and trigger resize
Co-authored-by: Michael Moschovas <mmoschovas@NY-Moschovas.local>
* Improve __uspapi behavior in iframe (#6072)
* align locator + fix remove listener
* update comment
Co-authored-by: Reinout Stevens <reinout@crazygames.com>
* Prebid 4.22.0 Release
* Increment pre version
* Sovrn: Add Support for Floor Module (#6155)
* EX-2549 Pass segments parameter as imp.ext.dealids array
* EX-2549 Address Jon's feedback
* EX-2549 Reworked the solution
* EX-2549 Blackbird compatibility
* EX-2549 Address Jon's comments
* EX-2549 Addressed upstream PR comments
* added floor module support
* added function check
* rerun test
Co-authored-by: Egor Gordeev <egordeev@lineate.com>
Co-authored-by: Egor Gordeev <48566506+egsgordeev@users.noreply.github.com>
* Lotame panorama id glv (#6185)
* Add the root domain check method as a global method added for use modules
* Add a date suffix to keep the test cookie random
* Per review, moved the findRootDomain method to utils out of the userId modules
* More the domain method back the user module but attach it to the submodule so that userId modules can have access to it
* Remove the storageManager as it is no longer used in utils
* Add the GVLID to the lotamePanoramaIdSystem
* Use the GVL ID in the storage manager as well
* Admixer bid adapter: add fpd (#6190)
* Migrating to Prebid 1.0
* Migrating to Prebid 1.0
* Fix spec
* add gdpr and usp
* remove changes in gdpr_hello_world.html
* Update gdpr_hello_world.html
add spaces
* add user syncs
* remove comments
* tests
* add fpd to request
Co-authored-by: atkachov <atkachov91@admixer.ua>
* Add Adomain Targeting Key and Default Targeting Keys (#6116)
* Add Adomain Targeting Key
* add default targeting key
Co-authored-by: Veronica Kim <vkim@vkim-mac.lan>
* Adkernel: torchad alias (#6191)
* New feature: PBS anti alias (#6150)
* PBS anti alias
* lint
* lint
* update test
* update test
* Unit tests + dynamic aliasing
* test bidder factory
* Waardex Bid Adapter: Add video support, refactor code (#6149)
* Add video support, refactor code
* Add zoneId, refactor
Co-authored-by: yegorheiz <yegorheiz@gmail.com>
* ID5 User Id Module: move id5's user id extension to the uids array (#6193)
* move id5's user id extension to the uids array to better conform to conventions
* update location of id5 ext in spotx bid adapter
* Add tapad id submodule (#6167)
* Add tapad id submodule
* clean and add specs
* GothamAds prebid adapter (#6180)
* init new pull request with GothamAds prebid adapter
* new optional params (#6148)
* Add the root domain check method as a util method added for use mod… (#6124)
* Add the root domain check method as a global method added for use modules
* Add a date suffix to keep the test cookie random
* Per review, moved the findRootDomain method to utils out of the userId modules
* More the domain method back the user module but attach it to the submodule so that userId modules can have access to it
* Remove the storageManager as it is no longer used in utils
* fix includes and find references in various files (#6183)
* Fix typo in mediaforce bid adapter (#6181)
* add mediaforce bid adapter
* make use of unused variable language
* Added native support for Mediaforce Bid Adapter
* Fix test endpoint url for Mediaforce Bid Adapter
* cleanup
* Added the ability to send multiple bids in one ad request for mediaforce bid adapter
* Fixes after review for mediaforce bid adapter
* Fix typo in mediaforce bid adapter
Co-authored-by: ksanksana <little.grey.goblin@gmail.com>
* Prebid JS Native Phase 2 update: (#5411)
* Prebid JS Native Phase 2 update:
1) Key Suppression for Native keys with sendTargetingKeys set to false at nativeParams.sendTargetingKeys or within asset i.e. nativeParams.image.sendTargetingKeys. Logic as follows:
- If nativeParams.sendTargetingKeys set to false but asset has sendTargetingKeys set to true then add the KV
- Else if nativeParams.sendTargetingKeys is set to true and asset does not have sendTargetingKeys defined or it is set to true then add KV
- Else if nativeParams.sendTargetingKeys is not defined and asset does not have sendTargetingKeys defined or it is set
to true then add KV
If no conditions met then key is suppressed
2) Adds rendererUrl or adTemplate to the bid object for easy retrieval if assets requested from creative
3) Adds new logic to receiveMessage function in secureCreatives.js to answer data.action of 'allAssetRequest' with all available assets on the bid that have a value
4) Adds new native keys to constants.json
* Update to simplify send asset logic
* Fixed asset location typo
* Update to include message listener for native resize and update adObject for auction to include creative height and trigger resize
Co-authored-by: Michael Moschovas <mmoschovas@NY-Moschovas.local>
* Improve __uspapi behavior in iframe (#6072)
* align locator + fix remove listener
* update comment
Co-authored-by: Reinout Stevens <reinout@crazygames.com>
* Prebid 4.22.0 Release
* Increment pre version
* Sovrn: Add Support for Floor Module (#6155)
* EX-2549 Pass segments parameter as imp.ext.dealids array
* EX-2549 Address Jon's feedback
* EX-2549 Reworked the solution
* EX-2549 Blackbird compatibility
* EX-2549 Address Jon's comments
* EX-2549 Addressed upstream PR comments
* added floor module support
* added function check
* rerun test
Co-authored-by: Egor Gordeev <egordeev@lineate.com>
Co-authored-by: Egor Gordeev <48566506+egsgordeev@users.noreply.github.com>
* Lotame panorama id glv (#6185)
* Add the root domain check method as a global method added for use modules
* Add a date suffix to keep the test cookie random
* Per review, moved the findRootDomain method to utils out of the userId modules
* More the domain method back the user module but attach it to the submodule so that userId modules can have access to it
* Remove the storageManager as it is no longer used in utils
* Add the GVLID to the lotamePanoramaIdSystem
* Use the GVL ID in the storage manager as well
* Admixer bid adapter: add fpd (#6190)
* Migrating to Prebid 1.0
* Migrating to Prebid 1.0
* Fix spec
* add gdpr and usp
* remove changes in gdpr_hello_world.html
* Update gdpr_hello_world.html
add spaces
* add user syncs
* remove comments
* tests
* add fpd to request
Co-authored-by: atkachov <atkachov91@admixer.ua>
* Add Adomain Targeting Key and Default Targeting Keys (#6116)
* Add Adomain Targeting Key
* add default targeting key
Co-authored-by: Veronica Kim <vkim@vkim-mac.lan>
* Adkernel: torchad alias (#6191)
* New feature: PBS anti alias (#6150)
* PBS anti alias
* lint
* lint
* update test
* update test
* Unit tests + dynamic aliasing
* test bidder factory
* Waardex Bid Adapter: Add video support, refactor code (#6149)
* Add video support, refactor code
* Add zoneId, refactor
Co-authored-by: yegorheiz <yegorheiz@gmail.com>
* init new pull request with GothamAds prebid adapter
Co-authored-by: Drilon Kastrati <drilon@gjirafa.com>
Co-authored-by: Mark <markaconrad@users.noreply.github.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Co-authored-by: Niksok <belnamtar@mail.ru>
Co-authored-by: ksanksana <little.grey.goblin@gmail.com>
Co-authored-by: mmoschovas <63253416+mmoschovas@users.noreply.github.com>
Co-authored-by: Michael Moschovas <mmoschovas@NY-Moschovas.local>
Co-authored-by: Reinout Stevens <reinout@reinoutstevens.be>
Co-authored-by: Reinout Stevens <reinout@crazygames.com>
Co-authored-by: Scott Menzer <scott@id5.io>
Co-authored-by: John Rosendahl <jrosendahl@gmail.com>
Co-authored-by: Egor Gordeev <egordeev@lineate.com>
Co-authored-by: Egor Gordeev <48566506+egsgordeev@users.noreply.github.com>
Co-authored-by: Galphimbl <sashatkachov91@gmail.com>
Co-authored-by: atkachov <atkachov91@admixer.ua>
Co-authored-by: Veronica Kim <43146383+vkimcm@users.noreply.github.com>
Co-authored-by: Veronica Kim <vkim@vkim-mac.lan>
Co-authored-by: Denis Logachov <denis@adkernel.com>
Co-authored-by: Gena <wertixvost@gmail.com>
Co-authored-by: yegorWaardex <59033363+yegorWaardex@users.noreply.github.com>
Co-authored-by: yegorheiz <yegorheiz@gmail.com>
* add AdTrue bid adapter (#6166)
* add AdTrue bid adapter
* add AdTrue Bid Adapter unit tests
* add AdTrue Bid Adapter unit tests
* add AdTrue bid adapter
* add AdTrue Bid Adapter unit tests
* add AdTrue Bid Adapter unit tests
* add AdTrue bid adapter
* Waardex Bid Adapter: use find function from core-js (#6200)
* Price Floors: use standard cpmAdjustment (#6194)
* use standard cpmAdjustment
* spaces
* move wrapper details into wrapper object (#6184)
* Fallback to utilize ad unit code if dmx id is not provide and increased TTL value (#6178)
* allow users to be sent to dmx even when gdpr is configured in prebid
* Change default ttl value
Change default ttl value for banner and video
* optional dmxid - fallback to use ad unit code
Co-authored-by: steve-a-districtm <56413795+steve-a-districtm@users.noreply.github.com>
* Rubicon analytics Adapter: Add logic to send batched message when slots render (#6188)
* adding logic to wait for slots to render before message
* Test updates
* Prebid 4.0.23 Release
* Increment pre version
* Lotame: added change to fall back to the TCF cookies when no data is present in the consentData object. (#6192)
* Lotame panorama id system updates (#6187)
* Add the root domain check method as a global method added for use modules
* Add a date suffix to keep the test cookie random
* Per review, moved the findRootDomain method to utils out of the userId modules
* More the domain method back the user module but attach it to the submodule so that userId modules can have access to it
* Remove the storageManager as it is no longer used in utils
* lotamePanoramaIdSubmodule: Add root cookie domain to all cookie writes
* lotamePanoramaIdSubmodule: Don't update profile id storage for a particular error
* lotamePanoramaIdSystem: Switch to indexOf instead of includes to support IE 11
* support outbrain alias in zemanta adapter (#6203)
* Yieldlab Adapter: Change URI of outstream renderer (#6211)
* Change OUTSTREAMPLAYER_URL
* Change OUTSTREAMPLAYER_URL
* Livewrapped: GVL id (#6208)
* Livewrapped bid and analytics adapter
* Fixed some tests for browser compatibility
* Fixed some tests for browser compatibility
* Changed analytics adapter code name
* Fix double quote in debug message
* modified how gdpr is being passed
* Added support for Publisher Common ID Module
* Corrections for ttr in analytics
* ANalytics updates
* Auction start time stamp changed
* Detect recovered ad blocked requests
Make it possible to pass dynamic parameters to adapter
* Collect info on ad units receiving any valid bid
* Support for ID5
Pass metadata from adapter
* Typo in test + eids on wrong level
* Fix for Prebid 3.0
* Fix get referer
* http -> https in tests
* Native support
* Read sizes from mediatype.banner
* Revert accidental commit
* Support native data collection + minor refactorings
* Set analytics endpoint
* Support for app parameters
* Fix issue where adunits with bids were not counted on reload
* Send debug info from adapter to external debugger
* SChain support
* Send GDPR data in analytics request
* video support
Video support
* Report back floor via analytic
* Send auction id and adunit/bidder connection id
* Criteo id support
* Updated example
* livewrapped Analytics Adapter info file
* Livewrapped gvlid
* IX Bid Adapter: Multiformat support, video adunit param, IXdiags (#6177)
* Multiformat support, video adunit param, IXdiags
* Lint fixing
* IE fix [cant handle includes]
* updated ixdiag count and validation logic
Co-authored-by: Ix-Prebid-Support <ix-prebid-support@indexexchange.com>
* Colossus Adapter: bidfloor support (#6199)
* add video&native traffic colossus ssp
* Native obj validation
* Native obj validation #2
* Added size field in requests
* fixed test
* fix merge conflicts
* move to 3.0
* move to 3.0
* fix IE11 new URL issue
* fix IE11 new URL issue
* fix IE11 new URL issue
* https for 3.0
* add https test
* add ccp and schain features
* fix test
* sync with upstream, fix conflicts
* Update colossussspBidAdapter.js
remove commented code
* Update colossussspBidAdapter.js
lint fix
* identity extensions
* identity extensions
* fix
* fix
* fix
* fix
* fix
* add tests for user ids
* fix
* fix
* fix
* fix
* fix
* fix
* fix
* add gdpr support
* add gdpr support
* id5id support
* Update colossussspBidAdapter.js
add bidfloor parameter
* Update colossussspBidAdapter.js
check bidfloor
* Update colossussspBidAdapter.js
* Update colossussspBidAdapter.js
* Update colossussspBidAdapter.js
* Update colossussspBidAdapter_spec.js
* use floor module
* Revert "use floor module"
This reverts commit f0c5c248627567e669d8eed4f2bb9a26a857e2ad.
* use floor module
Co-authored-by: Vladislav Isaiko <vladis@smartyads.com>
Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
* EMX revised issue with schain forwarding (#6080)
* adding ccpa support for emx_digital adapter
* emx_digital ccpa compliance: lint fix
* emx 3.0 compliance update
* fix outstream renderer issue, update test spec
* refactor formatVideoResponse function to use core-js/find
* Add support for schain forwarding
* Resolved issue with Schain object location
Co-authored-by: Nick Colletti <nick.colletti@emxdigital.com>
Co-authored-by: Nick Colletti <gnomish@gmail.com>
Co-authored-by: Kiyoshi Hara <Kiyoshi.Hara@emxdigital.com>
Co-authored-by: Dan Bogdan <daniel.bogdan@emxdigital.com>
Co-authored-by: Jherez Taylor <jherez.taylor@emxdigital.com>
Co-authored-by: EMXDigital <emxdigital@emxdigital.com>
Co-authored-by: Rakesh Balakrishnan <Rakesh.Balakrishnan@emxdigital.com>
* Criteo: Re-enable ad building when mediation is off and remove enableSendAllBids condition (#5900)
* typo and var name improvement (#6217)
Co-authored-by: karimJWP <karimJWP@github.com>
* Updating send json userids to endpoint in idLibrary (#6219)
* Updating send json userids
* Updating send json userids
* Updating send json userids
* Updating string user ids to json
Co-authored-by: skocheri <skocheri@rubiconproject.com>
* appnexus bid adapter - fix outstream render issue with smart ad server (#6215)
* add md file for tapadIdSystem (#6223)
* Implement glomex bid adapter (#6209)
* Implement glomexBidAdapter
* Implement glomexBidAdapter with tests and docs
Co-authored-by: Herb Dombrowski <32455795+hrb-d@users.noreply.github.com>
* JW Player RTD Module - Limit scope to adUnits supporting instream video (#6227)
* checks if media type is video and jwtargeting is present
* adds early return
* adds tests for jwtargeting with banner or outtream
Co-authored-by: karimJWP <karimJWP@github.com>
* Criteo: Increment adapter version (#6218)
* Triplelift Bid Adapter: Support for video floors (#6229)
* adds support for getFloor of video mediaTypes
* adds test for calling getFloor with correct mediaType
* checks that _getFloor converts string floors to float
Co-authored-by: Brandon Ling <51931757+blingster7@users.noreply.github.com>
* ATS Analytics: Send additional analytics data (#6145)
* ATS-analytics - add new way to detect browser and add envelope_source
* ATS-analytics - implement preflight logic
* ATS-analytics - change analytics prod url
* ATS-analytics - fix LGTM and add console log to atsAnalyticsAdapter test
* ATS-analytics - fix internet explorer 11 bug
* ATS-analytics - add logs on parseBrowser function
* ATS-analytics - try check with indexOf function
* ATS-analytics - fix sinon restore for ie11
* ATS-analytics - fix sinon restore for ie11
* ATS-analytics - try to fix sinon restore for ie11
* ATS-analytics - try to fix sinon restore for ie11
* ATS-analytics - refactor unit tests for userAgent
* [ATS-Analytics] - Added semicolons
Co-authored-by: Nemanja Rajkovic <n.rajkovic@levi9.com>
* Feature: Multiple Prebid Servers (#5992)
* adjusted for multiple prebid servers and added and adjusted units tests
* removed exra param
* fixed unit test
* adjusted testing module to work with mutliple configs
* Between multirequests (#6214)
* added multirequests
* const endpoint
Co-authored-by: Ignat Khaylov <khaylov@betweenx.com>
* Prebid 4.24.0 Release
* Increment pre version
* Fix astraoneBidAdapter (#6230)
* Fix astraoneBidAdapter
* Fix examples; update astraoneBidAdapter description
* Fix astraoneBidAdapter_spec
* Remove integration examples
* Rename gbt to gpt
* update banner ttl (#6228)
* browsi: updating test parameters (#6048)
* SpotX Bid Adapter: default to 4/3 aspect ratio when response doesn't contain w or h (#6159)
* Default to 4/3 aspect ratio when response doesn't contain w or h
* SpotX bid adapter: reorder tests and remove extra assertions
* Extended ID permissions supported by bidder (#6112)
* User id bidder permission scheme
* styling
* prebidServer support
* -
* fix
* prebidServerBidAdapter take eidPermissions directly from userId module
* -
* unit tests
* -
* -
* update
* -
* -
* changed pbjs_bidders to pbjsBidders
* changed pbjsBidders to bidders
ext.prebid.data.eidPermissions to ext.prebid.data.eidpermissions
* rerun circleci
* rerun circleci
* omitting eidPermission entry if 'bidders' is not configured
Co-authored-by: myerkovich <myerkovich@rubiconproject.com>
Co-authored-by: Marko Yerkovich <marko_yerkovich@MacBook-Pro-Marko.local>
* Relevant Yield analytics adapter (#6195)
* Pubmatic: fix issue where using an adUnit outstream renderer throws an error (#6152)
* Malltv Bid Adapter : added data object as a param (#6232)
* Updated malltv adapter
* Updated markdown
* Added test for malltvBidAdapter
* support setting coopSync in s2sConfig (#6213)
Co-authored-by: Mark Monday <mmonday@rubiconproject.com>
* Revert "support setting coopSync in s2sConfig (#6213)" (#6249)
This reverts commit 25dd35c99f404390242133b84245bb5cafeb7d7b.
* pbsBidAdapter: change order of client syncs (#6248)
* pbsBidAdapter: change order cookie_syncs
Prebid Server places cookie-sync URLs in a specific order. PBJS was pulling them off in reverse order.
* moving comment
* reverting coopSync
* pass a flag back to ID5 servers if abTesting was enabled by the publisher for monitoring usage of the feature (#6170)
* appneuxs Bid Adapter - add support for identitylink userId (#6245)
* Update britepoolIdSystem.md (#6254)
Eliot from Britepool says you can set just the api key without any params (eg ssid or hash)
* UNICORN Adapter - accept multiple formats (#6255)
* enable multiple formats
add version
* add banner w/h
* fix w/h & spec
* ATS-analytics - add comment clarifying ownership of atsAnalytics (#6257)
* [ParrableIdSystem] Ensure base64 payload is url-safe (#6258)
* Added url safe base64 encoding
* Added url safe base64 encoding test
Co-authored-by: Victor <victorigualada@gmail.com>
* Keywords + Screen resolution + CPU Core (#6259)
Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>
* Rubicon Analytics: Fire event once gptSlots render (#6241)
* Once all gam slots are back fire event
* push to cmd queue
* New dimension for tracking name of the matching adUnit pattern (#6252)
* Adhese Bid Adapter: Per adunit targets (#6256)
* adpod category support test
* Revert "adpod category support test"
* Gjirafa Bid Adapter: added data object as a param (#6231)
* Added data parameter to gjirafaBidAdapter
* Updated gjirafaBidAdapter markdown
* Added test for gjirafaBidAdapter
* Fix a TypeError when message event source is not available (#6224)
* fix broken tests due to "encoded" base64 logic (#6268)
* Adkernel Bid Adapter: stringads alias added (#6262)
* Adkernel: stringads alias
* Revert "Extended ID permissions supported by bidder (#6112)" (#6269)
This reverts commit a926dee9e108ca4b8792ba8992a9bca7c2f42781.
* Prebid 4.25.0 Release
* Increment pre version
* smartxBidAdapter: new Feature - Made Out-Stream Player configurable (#6239)
* Add smartclipBidAdapter
* smartxBidAdapter.js - removed unused variables, removed debug, added window before the outstream related functions
* - made outstream player configurable
* remove wrong named files
* camelcase
* fix
Co-authored-by: smartclip AdTechnology <adtech@smartclip.com>
Co-authored-by: Gino Cirlini <adtech@smartclip.tv>
* Idl1 (#6242)
* Renaming idLibrary to idImportLibrary
* Renaming idLibrary to idImportLibrary
Co-authored-by: skocheri <skocheri@rubiconproject.com>
* Add the trade desk gvlid (#6263)
UnifiedId only works with a vendor exception in the gdpr enforcement module.
However this is not okay as the unifiedId matching endpoint doesn't take the consent into account and
cookies are being dropped even without consent.
* pick up wrapper family detail (#6272)
* Add user sync (#6244)
* initial
* fix
* remove redundant language mod, use player sizes in video traff
* test modify
* fix
* Adding Tests
* add keywords param
* log
* log
* log
* fix
* add idl
* add idl
* fix test
* lint
* lint
* fix
* lint
* lint
* lint
* lint
* add sync
* fix
Co-authored-by: Aigolkin1991 <Aigolkin1991@gmail.com>
Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
* Zeotap id plus gvlid (#6260)
* Add gvlid for ZeotapIdPlus module
* Pass gvlid and module name to storage manager
* add testcases to zeotapIdPlusIdSystem
* remove unwanted code
* adWMG adapter: add new parameter, fix minor bugs (#6265)
* Support floorCPM parameter, fix some minor bugs
* fix space-in-parens circleci error
* example fix
* clean usersync URL
* spaces
* spaces
* add new unit tests, compatibility with IE11
* remove logInfo
Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us>
* [ParrableIdSystem] Supply iframe state to backend (#6278)
* Add iframe detection
* Remove forgotten .only
Co-authored-by: Victor <victorigualada@gmail.com>
* Bid Viewability Module (#6206)
* introducing a new event, bidViewable
* new module: bidViewability
* details in bidViewability.md
* disable webdriver tests in trionBidAdapter spec (#6280)
* [ParrableIdSystem] Supply Prebid library version to backend (#6279)
* Add prebid version to data object
* Renamed prebid to prebidVersion
* Fix missing coma
Co-authored-by: Victor <victorigualada@gmail.com>
* [ParrableIdSystem] Accept list of partners as an array or string (#6277)
* Accept partners as an array and fallthrough partner if no partners
* Ensure that Parrable data object decodes with urlsafe base64 in tests
* Fixed tests caused by typo in config property
* Fix failing test due to accessing unexisting property 'partner'
Co-authored-by: Victor <victorigualada@gmail.com>
* Rubicon Bid Adapter FPD Update (#6122)
* Update to consolidate applying FPD to both banner and video requests. FPD will be merged using global defined FPD, ad unit FPD, and rubicon bidder param FPD. Validation logic with warning logs added
* Refectored last push to:
1) Correct keywords bug
2) Revise error which looked for FPD in (user/context).ext.data as opposed to (user/context).data
3) General code cleanup
* Consolidated other FPD data logic into new function
* 1. Update to move pbadslot and adserver data into imp[] as opposed to parent.
2. Update to convert keywords passed through RP params to string if array found
* Removed unnecessary conditional
* Changed conditional to check for undefined type
* Update to consolidate several lines of duplicate code into one location
* ID5 User Id Module: update a/b testing to be user based not request based (#6281)
* convert A/B testing to be user-based, rather than request-based
* update docs to say a/b testing is user based, not request based
* Shared ID gdpr support (#6275)
* SharedId gdpr support
* Reverted commented locally failing tests
* Lemma:set mediaType key value (#6006)
* lemmaBidAdapter.js
Added lemma bid adapter file
* lemmaBidAdapter.md
Added lemma bid adapter md file
* lemmaBidAdapter_spec.js
Added lemma bid adapter test spec file
* Update lemmaBidAdapter.js
Fixed automated code review alert comparison between inconvertible types
* Update lemmaBidAdapter.js
Fixed review changes
* Update lemmaBidAdapter.md
Correct parameter value.
* Update lemmaBidAdapter.js
Lemma Bid Adapter - v3.0 compliance
* Update lemmaBidAdapter_spec.js
Lemma Bid Adapter - v3.0 compliance
* Update lemmaBidAdapter.md
Lemma Bid Adapter - v3.0 compliance
* Update lemmaBidAdapter.js
Added user sync support into bid adapter.
* updated include modules file extension.
updated include modules js file extension.
* Update lemmaBidAdapter_spec.js
Added unit test for user sync feature.
* Update lemmaBidAdapter.js
Fixed format error.
* Update lemmaBidAdapter_spec.js
Fixed format error and typo error.
* Set mediaType key value into bid object
Set mediaType key value into the bid object.
* Update lemmaBidAdapter.js
remove duplicate function
* Update lemmaBidAdapter.js
Remove non supported code.
* Update lemmaBidAdapter_spec.js
Remove GDPR test cases.
* added support for addtlConsent (#6005)
Co-authored-by: Ix-Prebid-Support <ix-prebid-support@indexexchange.com>
* Add bid adapter for Missena (#6247)
* adds support for getFloor of video mediaTypes
* adds test for calling getFloor with correct mediaType
* checks that _getFloor converts string floors to float
* Add bid adapter for Missena
* Use publisher demo token in tests
* Add Missena global vendor ID to spec
* Use apiKey in the current bidRequest
* Add referer info to payload
Co-authored-by: Nick Llerandi <nllerandi@triplelift.com>
Co-authored-by: Brandon Ling <51931757+blingster7@users.noreply.github.com>
Co-authored-by: Brandon Ling <bling@triplelift.com>
* Gulp test file example added in readme (#6287)
* Sharethrough: Add support for ID5, Shared ID, and Live Intent ID (#6261)
* Update prebid adapter universal ids to include ID5, SharedID, and LiveIntent ID.
[#176447070](https://www.pivotaltracker.com/story/show/176447070)
Co-authored-by: Mathieu Pheulpin <mpheulpin@sharethrough.com>
* Addressing review
[#176447070]
* Quick rewrite
[#176447070]
* Address ID5 review, forward linkType to adserver
* Reformatting SharedID to align with ID5
Co-authored-by: Mathieu Pheulpin <mpheulpin@sharethrough.com>
* SmartAdServer Bid Adapter: image sync and noAd (#6236)
* SIM-889 Now we have image based sync
* SIM-889 Added test to check noad and image sync
* SIM-889 Fixing indenting issues
* Add client Alias Adkernel (#6291)
Adding "bcm" alias to Adkernel adapter
* [ParrableIdSystem] Add GVLID and handle TC Consent data (#6283)
* Added GDPR support
* Remove forgotten .only
Co-authored-by: Victor <victorigualada@gmail.com>
* 4.26.0 release
* 4.27.0-pre
* Updated data mapping of winning bid and auction logs in pubxai analytics adapter (#6285)
Co-authored-by: Phaneendra Hegde <phaneendra.hegde@gmail.com>
* Grid Bid Adapter: Added video protocols to the ad request (#6299)
* Rubicon Bid Adapter: updated transactionId to auctionId for OpenRTB (#6298)
* Fix for Issue 6117: Added Module Name in Build to Comments (#6297)
* map tripleliftBidAdapter.js tl_source to bid.meta.mediaType (#6303)
* Tappx Bid Adapter: new bidder adapter added (#6233)
* ADD: tappx bid adapter
* FIX: replace .includes by .indexOf
* UPDATE: Expand the test coverage
* FIX: format spacing tests
* FIX: get auctionId from validBidRequests
* UPDATE: add bannerMediaType tablet sizes
* FIX: get timeout from bidderRequest.timeout
* UPDATE: replace the way to get the hostname
* UPDATE: adding support multiple bid requests in a single call
* UPDATE: remove hardcoded test payload param
Co-authored-by: marc_tappx <marc@tappx.com>
* Add Native ad capability to AdYouLike adapter (#6198)
* Remove useless bidderCode in bid response
* send all the available sizes in the bid request
* Use the banner sizes if given
* avoid compatibility issue with old bid format
* ad iframe and publisher domain paramters to bid requests
* add publisher domain info in ad request
* add a check in unit tests for publisherDomain
* encode uri components
* add native assets support
* add native information to ad request
* fix native ad parsing
* fix nativ condition to set mediatype
* fix image access and add trackers
* fix and add unit test on native ad
* update md file
* remove usage of URLSearchParams
* allox pure native ad with no adm provided
Co-authored-by: Guillaume <guiandouard@gmail.com>
* Update targeting.js to fix TTL buffer arithmetic (#6300)
* Permutive RTD submodule (#6290)
* Add Permutive RTD module
* set demo data in LS for test page
* fix linter issues
* reduce timeout on example page
* decrease sample timeouts
* rename targeting to segments
* Adtelligent Bid Adapter: Add Navelix as alias (#6306)
* Navelix bidder
* gvlID
Co-authored-by: susyt <susan@fox.camp>
Co-authored-by: Meng <5110935+edmonl@users.noreply.github.com>
Co-authored-by: jsnellbaker <31102355+jsnellbaker@users.noreply.github.com>
Co-authored-by: Harshad Mane <harshad.mane@pubmatic.com>
Co-authored-by: Reinout Stevens <reinout@reinoutstevens.be>
Co-authored-by: Reinout Stevens <reinout@crazygames.com>
Co-authored-by: Paul de Rosanbo <paul@rosanbo.com>
Co-authored-by: Samuel Adu <samuel.adu@gmail.com>
Co-authored-by: slimkrazy <sam@slimkrazy.com>
Co-authored-by: John Salis <jsalis531@gmail.com>
Co-authored-by: John Salis <johnsalis@beachfrontmedia.com>
Co-authored-by: jxdeveloper1 <71084096+jxdeveloper1@users.noreply.github.com>
Co-authored-by: Brandon Ling <51931757+blingster7@users.noreply.github.com>
Co-authored-by: nyakove <43004249+nyakove@users.noreply.github.com>
Co-authored-by: Mikhail Dykun <m.dykun@wmgroup.us>
Co-authored-by: cpuBird <54024689+cpuBird@users.noreply.github.com>
Co-authored-by: mmoschovas <63253416+mmoschovas@users.noreply.github.com>
Co-authored-by: Olivier <osazos@adagio.io>
Co-authored-by: Gena <wertixvost@gmail.com>
Co-authored-by: Mike Chowla <mike.chowla@pubmatic.com>
Co-authored-by: Scott Menzer <scott@id5.io>
Co-authored-by: olafbuitelaar <olaf.buitelaar@gmail.com>
Co-authored-by: Hiroaki Kubota <hiroaki.kubota@mail.crumb.jp>
Co-authored-by: Oleg Naydenov <onaydenov@users.noreply.github.com>
Co-authored-by: Mathieu Pheulpin <sokaru91@gmail.com>
Co-authored-by: Michael Duran <mduran@sharethrough.com>
Co-authored-by: Egor Gordeev <48566506+egsgordeev@users.noreply.github.com>
Co-authored-by: Adam Browning <19834421+adam-browning@users.noreply.github.com>
Co-authored-by: fgcloutier <fgc@adledge.com>
Co-authored-by: OneTagDevOps <38786435+OneTagDevOps@users.noreply.github.com>
Co-authored-by: francesco <f.orazini@onetag.com>
Co-authored-by: Rok Sušnik <rokostik@gmail.com>
Co-authored-by: Vadim Gush <vadim_gush@lineate.com>
Co-authored-by: pro-nsk <32703851+pro-nsk@users.noreply.github.com>
Co-authored-by: Artem Kostritsa <akostritsa@akostritsa.com>
Co-authored-by: Alexander Kascheev <akascheev@asteriosoft.com>
Co-authored-by: readpeaktuomo <66239046+readpeaktuomo@users.noreply.github.com>
Co-authored-by: Zak Andree <zandree@owneriq.com>
Co-authored-by: hybrid-ai <58724131+hybrid-ai@users.noreply.github.com>
Co-authored-by: s-shevtsov <s.shevtsov@targetix.net>
Co-authored-by: reemeng <29702905+reemeng@users.noreply.github.com>
Co-authored-by: TheMediaGrid <44166371+TheMediaGrid@users.noreply.github.com>
Co-authored-by: Newton <5769156+iamnewton@users.noreply.github.com>
Co-authored-by: wojciech-bialy-wpm <67895844+wojciech-bialy-wpm@users.noreply.github.com>
Co-authored-by: Wojciech Biały <wb@WojciechBialy.local>
Co-authored-by: Lisa Benmore <lbenmore@gmail.com>
Co-authored-by: Galphimbl <sashatkachov91@gmail.com>
Co-authored-by: mwehr-zeta <70167335+mwehr-zeta@users.noreply.github.com>
Co-authored-by: BertiBauer <14088844+BertiBauer@users.noreply.github.com>
Co-authored-by: Scott Floam <scottfloam@gmail.com>
Co-authored-by: liranbaruch <liranb@ironsrc.com>
Co-authored-by: Janko Ulaga <janko.ulaga@gmail.com>
Co-authored-by: Robert Ray Martinez III <rrmartinez1552@gmail.com>
Co-authored-by: Jozef Bartek <31618107+jbartek25@users.noreply.github.com>
Co-authored-by: Pub-X <63354024+Pub-X@users.noreply.github.com>
Co-authored-by: chino117 <chino117@hotmail.com>
Co-authored-by: ucfunnel <39581136+ucfunnel@users.noreply.github.com>
Co-authored-by: root <root@ubuntu.members.linode.com>
Co-authored-by: Ryan Chou <ryanchou0210@gmail.com>
Co-authored-by: jack.hsieh <moonnight8520@gmail.com>
Co-authored-by: msm0504 <51493331+msm0504@users.noreply.github.com>
Co-authored-by: Mark Monday <mmonday@rubiconproject.com>
Co-authored-by: Vidyome <35255015+vidyome@users.noreply.github.com>
Co-authored-by: RAJKUMAR NATARAJAN <raj.cs.psg@gmail.com>
Co-authored-by: Rajkumar Natarajan <rajkumar.natarajan@synacor.com>
Co-authored-by: noamtzuberi <Noam.Tzuberi@ironsrc.com>
Co-authored-by: Drilon Kastrati <drilon@gjirafa.com>
Co-authored-by: Mark <markaconrad@users.noreply.github.com>
Co-authored-by: Niksok <belnamtar@mail.ru>
Co-authored-by: ksanksana <little.grey.goblin@gmail.com>
Co-authored-by: Michael Moschovas <mmoschovas@NY-Moschovas.local>
Co-authored-by: John Rosendahl <jrosendahl@gmail.com>
Co-authored-by: Egor Gordeev <egordeev@lineate.com>
Co-authored-by: atkachov <atkachov91@admixer.ua>
Co-authored-by: Veronica Kim <43146383+vkimcm@users.noreply.github.com>
Co-authored-by: Veronica Kim <vkim@vkim-mac.lan>
Co-authored-by: Denis Logachov <denis@adkernel.com>
Co-authored-by: yegorWaardex <59033363+yegorWaardex@users.noreply.github.com>
Co-authored-by: yegorheiz <yegorheiz@gmail.com>
Co-authored-by: Maurice Roach <maurice.roach@tapad.com>
Co-authored-by: supportGothamad <75782642+supportGothamad@users.noreply.github.com>
Co-authored-by: Hai Lee <lx@adtrue.com>
Co-authored-by: Filip Stamenkovic <ficadub@gmail.com>
Co-authored-by: Tucker <72400387+MenelikTucker-districtm@users.noreply.github.com>
Co-authored-by: steve-a-districtm <56413795+steve-a-districtm@users.noreply.github.com>
Co-authored-by: Eric Harper <eharper@rubiconproject.com>
Co-authored-by: Mike Marcus <mike@lotame.com>
Co-authored-by: Rok Sušnik <rsusnik@outbrain.com>
Co-authored-by: bjorn-lw <32431346+bjorn-lw@users.noreply.github.com>
Co-authored-by: Kajan Umakanthan <umakajan@umakajan.com>
Co-authored-by: Ix-Prebid-Support <ix-prebid-support@indexexchange.com>
Co-authored-by: Bill Newman <huddled.masses1650@gmail.com>
Co-authored-by: Vladislav Isaiko <vladis@smartyads.com>
Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
Co-authored-by: Dan Bogdan <43830380+EMXDigital@users.noreply.github.com>
Co-authored-by: Nick Colletti <nick.colletti@emxdigital.com>
Co-authored-by: Nick Colletti <gnomish@gmail.com>
Co-authored-by: Kiyoshi Hara <Kiyoshi.Hara@emxdigital.com>
Co-authored-by: Dan Bogdan <daniel.bogdan@emxdigital.com>
Co-authored-by: Jherez Taylor <jherez.taylor@emxdigital.com>
Co-authored-by: EMXDigital <emxdigital@emxdigital.com>
Co-authored-by: Rakesh Balakrishnan <Rakesh.Balakrishnan@emxdigital.com>
Co-authored-by: oasis <2394426+bmwcmw@users.noreply.github.com>
Co-authored-by: Karim Mourra <karim@jwplayer.com>
Co-authored-by: karimJWP <karimJWP@github.com>
Co-authored-by: SKOCHERI <37454420+SKOCHERI@users.noreply.github.com>
Co-authored-by: skocheri <skocheri@rubiconproject.com>
Co-authored-by: Neelanjan Sen <14229985+Fawke@users.noreply.github.com>
Co-authored-by: Julian Hollmann <julian.hollmann@googlemail.com>
Co-authored-by: Herb Dombrowski <32455795+hrb-d@users.noreply.github.com>
Co-authored-by: nllerandi3lift <75995508+nllerandi3lift@users.noreply.github.com>
Co-authored-by: mamatic <52153441+mamatic@users.noreply.github.com>
Co-authored-by: Nemanja Rajkovic <n.rajkovic@levi9.com>
Co-authored-by: Ryan Schweitzer <50628828+r-schweitzer@users.noreply.github.com>
Co-authored-by: Ignat Khaylov <ignat@ignat.one>
Co-authored-by: Ignat Khaylov <khaylov@betweenx.com>
Co-authored-by: Liza Kobrazova <lizakobrazova@gmail.com>
Co-authored-by: Steve Alliance <steve.alliance@gmail.com>
Co-authored-by: bretg <bgorsline@gmail.com>
Co-authored-by: Amanda Dillon <41923726+agdillon@users.noreply.github.com>
Co-authored-by: YerkovichM <48519843+YerkovichM@users.noreply.github.com>
Co-authored-by: myerkovich <myerkovich@rubiconproject.com>
Co-authored-by: Marko Yerkovich <marko_yerkovich@MacBook-Pro-Marko.local>
Co-authored-by: samuel-palmer-relevant-digital <77437973+samuel-palmer-relevant-digital@users.noreply.github.com>
Co-authored-by: pm-shashank-jain <40654031+pm-shashank-jain@users.noreply.github.com>
Co-authored-by: ardit-baloku <77985953+ardit-baloku@users.noreply.github.com>
Co-authored-by: Patrick McCann <patmmccann@gmail.com>
Co-authored-by: Kotaro Shikata <lim.0.ctyl@gmail.com>
Co-authored-by: Ian Flournoy <ian@parrable.com>
Co-authored-by: Victor <victorigualada@gmail.com>
Co-authored-by: Rich Audience <integrations@richaudience.com>
Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>
Co-authored-by: mefjush <mefjush@gmail.com>
Co-authored-by: Catalin Ciocov <catalin.ciocov@gmail.com>
Co-authored-by: harpere <ericsbiz@yahoo.com>
Co-authored-by: Skylinar <53079123+Skylinar@users.noreply.github.com>
Co-authored-by: smartclip AdTechnology <adtech@smartclip.com>
Co-authored-by: Gino Cirlini <adtech@smartclip.tv>
Co-authored-by: Nepomuk Seiler <muuki88@users.noreply.github.com>
Co-authored-by: Adprime <64427228+Adprime@users.noreply.github.com>
Co-authored-by: Aigolkin1991 <Aigolkin1991@gmail.com>
Co-authored-by: shikharsharma-zeotap <shikhar.sharma@zeotap.com>
Co-authored-by: Ian Flournoy <ian@flournoy.us>
Co-authored-by: Lemma Dev <54662130+lemmadev@users.noreply.github.com>
Co-authored-by: ix-certification <adapter-certification-eng@indexexchange.com>
Co-authored-by: Missena <78362128+dev-missena@users.noreply.github.com>
Co-authored-by: Nick Llerandi <nllerandi@triplelift.com>
Co-authored-by: Brandon Ling <bling@triplelift.com>
Co-authored-by: Pooja Pasawala <poojapasawala@gmail.com>
Co-authored-by: Mathieu Pheulpin <mpheulpin@sharethrough.com>
Co-authored-by: lowendavid <66423906+lowendavid@users.noreply.github.com>
Co-authored-by: iskmerof <matt.foremski@gmail.com>
Co-authored-by: Matt Kendall <1870166+mkendall07@users.noreply.github.com>
Co-authored-by: pnh-pubx <73683023+pnh-pubx@users.noreply.github.com>
Co-authored-by: Phaneendra Hegde <phaneendra.hegde@gmail.com>
Co-authored-by: prebidtappx <77485538+prebidtappx@users.noreply.github.com>
Co-authored-by: marc_tappx <marc@tappx.com>
Co-authored-by: guiann <guillaume.andouard@adyoulike.com>
Co-authored-by: Guillaume <guiandouard@gmail.com>
Co-authored-by: David Reischer <reischer.david@gmail.com>
stsepelin
pushed a commit
to cointraffic/Prebid.js
that referenced
this pull request
May 28, 2021
* Fix __tcfapi declaration in iframe * Add tests for cmp declaration in iframe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
When prebid is loaded in an iframe, a __cmp or __tcfapi function is created to forward calls to the parent frame CMP using the locator. The created __tcfapi function have the arguments of the CMP v1 specification.
This fix change the function declaration anduse 4 arguments according to spec
https://github.com/InteractiveAdvertisingBureau/GDPR-Transparency-and-Consent-Framework/blob/master/TCFv2/IAB%20Tech%20Lab%20-%20CMP%20API%20v2.md#how-does-the-cmp-provide-the-api
Other information
issue #5976