-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gulp Review-Start Task #6067
Merged
Merged
Changes from 13 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
66d2022
Merge pull request #2 from prebid/master
GLStephen c23b8eb
Merge pull request #3 from prebid/master
GLStephen b17b055
Merge pull request #4 from prebid/master
GLStephen 46398a9
Merge pull request #5 from prebid/master
GLStephen 84c9cdb
Merge pull request #6 from prebid/master
GLStephen ef0edd5
Merge remote-tracking branch 'upstream/master'
GLStephen 6d091ae
Merge remote-tracking branch 'upstream/master'
GLStephen 029842f
Merge remote-tracking branch 'upstream/master'
GLStephen 2528070
add review-start gulp command
GLStephen ecf1fa2
remove watch, unecessary for reviews
GLStephen 36c2ba0
add instructions to reviewer file for new command
GLStephen 15453ae
Updates to add back watch
GLStephen 5469821
updates to had reviewer hub page
GLStephen 3cb18de
Update PR_REVIEW.md
GLStephen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<html lang="en"> | ||
<head> | ||
<!-- | ||
This page provides links to common reviewer tools, tips and tricks. | ||
--> | ||
<meta charset="utf-8"> | ||
<meta name="viewport" content="width=device-width, initial-scale=1"> | ||
|
||
<title>Prebid Reviewer Tools</title> | ||
<style> | ||
.section{padding-top:40px;} | ||
.container{max-width:600px;margin:0 auto;} | ||
</style> | ||
</head> | ||
|
||
<body> | ||
<div class="section"> | ||
<div class="container"> | ||
<div class="row"> | ||
<h1>Reviewer Tools</h1> | ||
<p>Below are links to the most common tool used by Prebid reviewers. For more info on PR review processes check out the <a href="https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md">General PR Review Process</a> page on Github.</p> | ||
<h2>Common</h2> | ||
<ul> | ||
<li><a href="/build/coverage/lcov-report">Code Coverage</a></li> | ||
<li><a href="/integrationExamples/gpt/hello_world.html">Hello World</a></li> | ||
</ul> | ||
<h2>Other Tools</h2> | ||
<ul> | ||
<li><a href="/integrationExamples/">Other Integration Examples</a></li> | ||
</ul> | ||
<h2>Documentation & Training Material</h2> | ||
<ul> | ||
<li><a href="https://github.com/prebid/Prebid.js/blob/master/PR_REVIEW.md">General PR Review Process</a></li> | ||
<li><a href="https://youtu.be/aNCJ_Ct6Q8Y">Reviewer Video</a></li> | ||
</ul> | ||
</div> | ||
</div> | ||
</div> | ||
</body> | ||
</html> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GLStephen Great work, I really like the idea of a reviewer dedicated page. Now, do we wanna get rid of these lines, since running
gulp review-start
will now do all the magic?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to leave them but add them as the "manual" option. I'll clarify it a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Fawke updated