Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GVLID RichaudienceAdapter #6071

Merged
merged 2 commits into from
Dec 4, 2020
Merged

Add GVLID RichaudienceAdapter #6071

merged 2 commits into from
Dec 4, 2020

Conversation

richaudience
Copy link
Contributor

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • [ x ] Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

Add GVLID in RichaudienceAdapter

  • test parameters for validating bids
{
  bidder: '<bidder name>',
  params: {
    // ...
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@bretg
Copy link
Collaborator

bretg commented Dec 2, 2020

@richaudience - need to remove package-lock.json from this PR. Thanks.

@richaudience
Copy link
Contributor Author

Hey @bretg
I have already applied the change-
Cheers

Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richaudience,

This looks good. I saw the docs for your adapter on Prebid.org, you can make it more descriptive by adding a few more things. For example,

gdpr_supported: true
gvl_id: 108

You can refer to the docs of some other adapters like appnexus or rubicon and see other meta data that you can add. (There are a lot of options, the more you add to the docs, easier for your users to see what features you provide)

@bretg
Copy link
Collaborator

bretg commented Dec 3, 2020

@richaudience
Copy link
Contributor Author

Hey guys
I have already uploaded the modification in prebid.io.
prebid/prebid.github.io#2550
Cheers

@bretg bretg removed the needs docs label Dec 3, 2020
@bretg bretg requested a review from Fawke December 3, 2020 17:57
Copy link
Contributor

@Fawke Fawke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fawke Fawke added the LGTM label Dec 4, 2020
@Fawke Fawke merged commit 8107da6 into prebid:master Dec 4, 2020
stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
* Add GVLID RichaudienceAdapter

* Update package-lock.json

Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants