-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GVLID RichaudienceAdapter #6071
Conversation
@richaudience - need to remove package-lock.json from this PR. Thanks. |
Hey @bretg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I saw the docs for your adapter on Prebid.org, you can make it more descriptive by adding a few more things. For example,
gdpr_supported: true
gvl_id: 108
You can refer to the docs of some other adapters like appnexus or rubicon and see other meta data that you can add. (There are a lot of options, the more you add to the docs, easier for your users to see what features you provide)
Specifically this file -- https://github.com/prebid/prebid.github.io/blob/master/dev-docs/bidders/richaudience.md |
Hey guys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add GVLID RichaudienceAdapter * Update package-lock.json Co-authored-by: sgimenez <sergi.gimenez@richaudience.com>
Type of change
Description of change
Add GVLID in RichaudienceAdapter
Be sure to test the integration with your adserver using the Hello World sample page.
For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:
Other information