Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prebid auctions #609

Closed
wants to merge 11 commits into from
Closed

Prebid auctions #609

wants to merge 11 commits into from

Conversation

protonate
Copy link
Collaborator

@mkendall07 for initial review. Adapters and tests need to be updated still.

@nanek
Copy link
Contributor

nanek commented Sep 9, 2016

This looks like a fairly large change. Can you provide clarity on the goal of this effort? I have some more questions, but before diving too deep, I'd like to understand more. Thanks!

@mkendall07
Copy link
Member

@nanek
The ability to "prefetch" demand with prebid.js has been an often requested feature. We've attempted various approaches to doing this, however, they have all been unsuccessful, largely do to the existing architecture never having a concept of an "auction", it had always used globals to contain all the data about any particular request/response. We have considered this at length and decided the best approach would be to encapsulate all the related data about an auction into an instance variable and conduct our requests/responses inside the instance. This PR is the culmination of finishing that work.

@nedstankus
Copy link
Contributor

@mkendall07 This sounds like a great addition. Do you expect the auction encapsulation to resolve issues with concurrent requests? I believe the previous prebid-auctions branch was intended to.

@mkendall07 mkendall07 closed this Sep 19, 2016
@mkendall07
Copy link
Member

Closing as this isn't ready yet

@protonate protonate deleted the prebid-auctions branch November 3, 2016 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants