Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended ID permissions supported by bidder #6112
Extended ID permissions supported by bidder #6112
Changes from 10 commits
3d6fa0d
4ba6262
bed0de2
514c235
38027f2
a8bf123
2f71551
09578e8
5e5b15c
9704d59
42dd118
2e7b77a
678532a
90acfd8
c4dc794
0d1f714
eaa844d
ebacc83
6adf98d
a805fed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this list of bidders is being sent to SSPs and likely will land in OpenRTB bid requests, should the name
bidders
in the eids object be changed topbjs_bidders
since it won't really apply to the openrtb world?also, rather than
['*']
can we just omitbidders
(orpbjs_bidders
) altogether if none were set? This will avoid sending a field that isn't necessaryThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdwieland8282
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smenzer changing bidders to pbjs_bidders seems fine to me. And yeah I agree omitting
pbjs_bidders
if none are set makes sense. Thanks.