Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TE Medya Prebid Adapter #6151

Closed
wants to merge 13 commits into from
Closed

TE Medya Prebid Adapter #6151

wants to merge 13 commits into from

Conversation

vidyome
Copy link
Contributor

@vidyome vidyome commented Dec 24, 2020

Hello,
We have completed the prebid adapter development for our TE Medya advertisement panel. We ran the tests and checked that it works. I request your review.
Best.

Type of change

  • New bidder adapter

Description of change

  • test parameters for validating bids
{
  bidder: 'temedya',
  params: {
    widgetId: 753497,
    count: 1
  }
}

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • [prebid@temedya.com] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@vidyome
Copy link
Contributor Author

vidyome commented Jan 6, 2021

Hello @aleksatr ,
I wish you a healthy year. I removed the conflicting file before, what can I do now?
Best.

@aleksatr
Copy link
Contributor

aleksatr commented Jan 6, 2021

Hi @vidyome , thanks, I wish you all the best as well. Conflict with package-lock.json can't be resolved by removing that file, removing it is another type of change made to that file, which will again be in conflict with changes made on the master branch.
You need to revert all changes you made to package-lock.json.
Maybe the easiest way of doing it, in this case, is to just git reset --soft HEAD^ enough times until you undo all your commits, then you unstage package-lock.json and revert the changes you made to that file, after that, you commit the changes you want and push again (will require git push --force). There are probably other ways of achieving the same, but this is how I would do it here.
You will end up with a single commit containing all your changes.
Also, make sure you add unit tests, providing at least 80% of coverage to your adapter. To generate and view the code coverage reports:

gulp test-coverage
gulp view-coverage

Also, make sure you attach a link to a PR you opened on https://github.com/prebid/prebid.github.io/

@vidyome vidyome closed this Jan 6, 2021
@aleksatr aleksatr mentioned this pull request Jan 6, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants