Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotame TCF fall back to cookies when consent data is otherwise unavailable #6192

Merged
merged 2 commits into from
Jan 21, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions modules/lotamePanoramaIdSystem.js
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,22 @@ export const lotamePanoramaIdSubmodule = {
queryParams.fp = storedUserId;
}

if (consentData && utils.isBoolean(consentData.gdprApplies)) {
queryParams.gdpr_applies = consentData.gdprApplies;
if (consentData.gdprApplies) {
queryParams.gdpr_consent = consentData.consentString;
let consentString;
if (consentData) {
if (utils.isBoolean(consentData.gdprApplies)) {
queryParams.gdpr_applies = consentData.gdprApplies;
}
consentString = consentData.consentString;
}
// If no consent string, try to read it from 1st party cookies
if (!consentString) {
consentString = getFromStorage('eupubconsent-v2');
}
if (!consentString) {
consentString = getFromStorage('euconsent-v2');
}
if (consentString) {
queryParams.gdpr_consent = consentString;
}
const url = utils.buildUrl({
protocol: 'https',
Expand Down
174 changes: 170 additions & 4 deletions test/spec/modules/lotamePanoramaIdSystem_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -440,10 +440,176 @@ describe('LotameId', function() {
});
});

it('should retrieve the id when decode is called', function() {
var id = lotamePanoramaIdSubmodule.decode('1234');
expect(id).to.be.eql({
'lotamePanoramaId': '1234'
describe('when gdpr applies and falls back to eupubconsent cookie', function () {
let request;
let callBackSpy = sinon.spy();
let consentData = {
gdprApplies: true,
consentString: undefined
};

beforeEach(function () {
getCookieStub
.withArgs('eupubconsent-v2')
.returns('consentGiven');

let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback;
submoduleCallback(callBackSpy);

// the contents of the response don't matter for this
request = server.requests[0];
request.respond(200, responseHeader, '');
});

it('should call the remote server when getId is called', function () {
expect(callBackSpy.calledOnce).to.be.true;
});

it('should pass the gdpr consent string back', function() {
expect(request.url).to.be.eq(
'https://id.crwdcntrl.net/id?gdpr_applies=true&gdpr_consent=consentGiven'
);
});
});

describe('when gdpr applies and falls back to euconsent cookie', function () {
let request;
let callBackSpy = sinon.spy();
let consentData = {
gdprApplies: true,
consentString: undefined
};

beforeEach(function () {
getCookieStub
.withArgs('euconsent-v2')
.returns('consentGiven');

let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback;
submoduleCallback(callBackSpy);

// the contents of the response don't matter for this
request = server.requests[0];
request.respond(200, responseHeader, '');
});

it('should call the remote server when getId is called', function () {
expect(callBackSpy.calledOnce).to.be.true;
});

it('should pass the gdpr consent string back', function() {
expect(request.url).to.be.eq(
'https://id.crwdcntrl.net/id?gdpr_applies=true&gdpr_consent=consentGiven'
);
});
});

describe('when gdpr applies but no consent string is available', function () {
let request;
let callBackSpy = sinon.spy();
let consentData = {
gdprApplies: true,
consentString: undefined
};

beforeEach(function () {
let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback;
submoduleCallback(callBackSpy);

// the contents of the response don't matter for this
request = server.requests[0];
request.respond(200, responseHeader, '');
});

it('should call the remote server when getId is called', function () {
expect(callBackSpy.calledOnce).to.be.true;
});

it('should not include the gdpr consent string on the url', function() {
expect(request.url).to.be.eq(
'https://id.crwdcntrl.net/id?gdpr_applies=true'
);
});
});

describe('when no consentData and falls back to eupubconsent cookie', function () {
let request;
let callBackSpy = sinon.spy();
let consentData;

beforeEach(function () {
getCookieStub
.withArgs('eupubconsent-v2')
.returns('consentGiven');

let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback;
submoduleCallback(callBackSpy);

// the contents of the response don't matter for this
request = server.requests[0];
request.respond(200, responseHeader, '');
});

it('should call the remote server when getId is called', function () {
expect(callBackSpy.calledOnce).to.be.true;
});

it('should pass the gdpr consent string back', function() {
expect(request.url).to.be.eq(
'https://id.crwdcntrl.net/id?gdpr_consent=consentGiven'
);
});
});

describe('when no consentData and falls back to euconsent cookie', function () {
let request;
let callBackSpy = sinon.spy();
let consentData;

beforeEach(function () {
getCookieStub
.withArgs('euconsent-v2')
.returns('consentGiven');

let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback;
submoduleCallback(callBackSpy);

// the contents of the response don't matter for this
request = server.requests[0];
request.respond(200, responseHeader, '');
});

it('should call the remote server when getId is called', function () {
expect(callBackSpy.calledOnce).to.be.true;
});

it('should pass the gdpr consent string back', function() {
expect(request.url).to.be.eq(
'https://id.crwdcntrl.net/id?gdpr_consent=consentGiven'
);
});
});

describe('when no consentData and no cookies', function () {
let request;
let callBackSpy = sinon.spy();
let consentData;

beforeEach(function () {
let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback;
submoduleCallback(callBackSpy);

// the contents of the response don't matter for this
request = server.requests[0];
request.respond(200, responseHeader, '');
});

it('should call the remote server when getId is called', function () {
expect(callBackSpy.calledOnce).to.be.true;
});

it('should pass the gdpr consent string back', function() {
expect(request.url).to.be.eq('https://id.crwdcntrl.net/id');
});
});
});