Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AdYoulike Bid Adapter: Add an "Insertion" tracking for Native mediatype #6481

Merged
merged 21 commits into from
Mar 31, 2021
Merged

AdYoulike Bid Adapter: Add an "Insertion" tracking for Native mediatype #6481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
1f1973d
read and send getFloor value
guiann Mar 3, 2021
596c02d
improve robustness on OnEvent fields
guiann Mar 3, 2021
ffef733
add video mediatype to adyoulike adapter
guiann Mar 3, 2021
5ec1be0
improve robustness on OnEvent fields
guiann Mar 3, 2021
9095a91
Merge branch 'FixOnEventError'
guiann Mar 4, 2021
22e7a67
Merge remote-tracking branch 'origin/master'
guiann Mar 8, 2021
6f9f118
Merge branch 'master' into Ayl-ReadFloor
guiann Mar 8, 2021
de3ba28
handle instream cases
guiann Mar 8, 2021
de52132
minor format fix
guiann Mar 8, 2021
dad93d7
move the atob call to apply it on every Vast response
guiann Mar 9, 2021
0cc02bd
Merge branch 'Ayl-ReadFloor'
guiann Mar 9, 2021
62af7ff
update adyoulike md file with video type
guiann Mar 9, 2021
c2839ea
Merge remote-tracking branch 'origin/master'
guiann Mar 10, 2021
3a783ec
update adyoulike bidder doc
guiann Mar 17, 2021
5338c6b
Merge remote-tracking branch 'origin/master'
guiann Mar 22, 2021
7044de3
fix merge error on 'bid' var name
guiann Mar 22, 2021
ad9658b
update adyoulike bidder doc
guiann Mar 25, 2021
2e06ff3
Merge remote-tracking branch 'origin/master'
guiann Mar 26, 2021
97bf6f9
add insertion event
guiann Mar 26, 2021
d5be6fc
add missing campaign ID parameter
guiann Mar 26, 2021
8f00e78
update unit test withnew tracking checked
guiann Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/adyoulikeBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,9 +339,12 @@ function getNativeAssets(response, nativeConfig) {

var impressionUrl = adJson.TrackingPrefix +
'/pixel?event_kind=IMPRESSION&attempt=' + adJson.Attempt;
var insertionUrl = adJson.TrackingPrefix +
'/pixel?event_kind=INSERTION&attempt=' + adJson.Attempt;

if (adJson.Campaign) {
impressionUrl += '&campaign=' + adJson.Campaign;
insertionUrl += '&campaign=' + adJson.Campaign;
}

native.clickUrl = adJson.TrackingPrefix + '/ar?event_kind=CLICK&attempt=' + adJson.Attempt +
Expand All @@ -355,7 +358,7 @@ function getNativeAssets(response, nativeConfig) {
native.impressionTrackers = [];
}

native.impressionTrackers.push(impressionUrl);
native.impressionTrackers.push(impressionUrl, insertionUrl);
}

Object.keys(nativeConfig).map(function(key, index) {
Expand Down
3 changes: 2 additions & 1 deletion test/spec/modules/adyoulikeBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -596,7 +596,8 @@ describe('Adyoulike Adapter', function () {
},
impressionTrackers: [
'https://testPixelIMP.com/fake',
'https://tracking.omnitagjs.com/tracking/pixel?event_kind=IMPRESSION&attempt=a11a121205932e75e622af275681965d&campaign=f1c80d4bb5643c222ae8de75e9b2f991'
'https://tracking.omnitagjs.com/tracking/pixel?event_kind=IMPRESSION&attempt=a11a121205932e75e622af275681965d&campaign=f1c80d4bb5643c222ae8de75e9b2f991',
'https://tracking.omnitagjs.com/tracking/pixel?event_kind=INSERTION&attempt=a11a121205932e75e622af275681965d&campaign=f1c80d4bb5643c222ae8de75e9b2f991'
],
javascriptTrackers: [
'https://testJsIMP.com/fake.js'
Expand Down