Yieldmo adapter: cut banner bid request parameters in case the url for banner request is too long

[ym-atsymuk]

Type of change

• Bugfix
• Feature
• New bidder adapter
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Does this change affect user-facing APIs or examples documented on http://prebid.org?
• Other

Description of change

Cut banner bid request parameters in case the url for banner request is too long

contact email of the adapter’s maintainer: opensource@yieldmo.com

• official adapter submission

[patmmccann]

Why not just do a post

[ym-atsymuk]

Why not just do a post

thank you. we will consider this option

[patmmccann]

This could work as a bridge, are you sure you don't want this temporarily?

[ym-atsymuk]

This could work as a bridge, are you sure you don't want this temporarily?

currently we does not support POST for banner requests, so we decided to go with this variant temporarily

[robertrmartinez]

Not sure our transpiler handles the for... of for IE. So some tests will fail in IE I am guessing.

So please update this to use ES5 if possible!

[FilipStamenkovic]

I think our transpiler will handle for... of loop even for IE. Looking at the build I see that this loop was changed to:

var _iterator = _createForOfIteratorHelper(BANNER_REQUEST_PROPERTIES_TO_REDUCE),
    _step;

try {
  for (_iterator.s(); !(_step = _iterator.n()).done;) {
    var property = _step.value;
    extraCharacters = shortcutProperty(extraCharacters, serverRequest, property);

    if (extraCharacters <= 0) {
      break;
    }
  }
} catch (err) {
  _iterator.e(err);
} finally {
  _iterator.f();
}

But, I would also suggest, if possible, not to use for... of loop, simply because built .js file would have less code and it would be a bit smaller.

[FilipStamenkovic]

Your tests are failing, according to the circleci, 9 tests are failing.
Can you update your code/tests?

Also, please take a look at the discussion for for... of loop.

[FilipStamenkovic]

I think our transpiler will handle for... of loop even for IE. Looking at the build I see that this loop was changed to:

var _iterator = _createForOfIteratorHelper(BANNER_REQUEST_PROPERTIES_TO_REDUCE),
    _step;

try {
  for (_iterator.s(); !(_step = _iterator.n()).done;) {
    var property = _step.value;
    extraCharacters = shortcutProperty(extraCharacters, serverRequest, property);

    if (extraCharacters <= 0) {
      break;
    }
  }
} catch (err) {
  _iterator.e(err);
} finally {
  _iterator.f();
}

But, I would also suggest, if possible, not to use for... of loop, simply because built .js file would have less code and it would be a bit smaller.

[ym-atsymuk]

Your tests are failing, according to the circleci, 9 tests are failing.
Can you update your code/tests?

Also, please take a look at the discussion for for... of loop.

Thank you for your feedback. for... of replaced with simple for loop.

Which tests are failing? On my local env tests are green

[FilipStamenkovic]

@ym-atsymuk Take a look at the circleci output:

https://app.circleci.com/pipelines/github/prebid/Prebid.js/4991/workflows/bf6594f1-7372-4a70-a411-6d2ee7ed4d3c/jobs/13345

[ym-atsymuk]

@ym-atsymuk Take a look at the circleci output:

https://app.circleci.com/pipelines/github/prebid/Prebid.js/4991/workflows/bf6594f1-7372-4a70-a411-6d2ee7ed4d3c/jobs/13345

fixed

[FilipStamenkovic]

LGTM