Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AOL Bid Adapter: add support for the floors module #6657

Closed
wants to merge 22 commits into from

Conversation

patmmccann
Copy link
Collaborator

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Other information

Partial solution to #6465

@adam-browning
Copy link
Contributor

adam-browning commented May 4, 2021

Hey @patmmccann,
When reviewing the implementation, I do not think it supports upstream price-floors at all since the requests are tag based to the SSP server and not in ORTB.
I might be wrong.
This adapter is maintained by the display part of our company so @slimkrazy should be the right person to assist.

I will also contact him internally.
Cheers!
Adam

@patmmccann
Copy link
Collaborator Author

if the floors don't work on this module, why not just delete on Line 274

if (params.bidFloor) {
  queryParams.bidfloor = params.bidFloor;
}

and you'll be fine for 5.0

@adam-browning @slimkrazy

@adam-browning
Copy link
Contributor

Hi @patmmccann,
Sorry for the delayed response.

The aolBidAdapter has 2 bidders within it: onedisplay & onemobile.
Although onedisplay supported passing a the bidFloor parameter, it is just a server side pass back over to the onemobile platform.
Since onemobile does not support bidFloor via tag integrations, this delclaration is now redundant and will have no affect server side.

There is a new Adapter that was supposed to replace both aol & oneMobile adapters called the verizonMediaBidAdapter.js
But due to obvious reasons (Verizon Media rebranding to Yahoo under Apollo) there will be some delays.
bidfloor can be ignored at this point.
Thanks in advance!
Adam

@patmmccann
Copy link
Collaborator Author

thank you @adam-browning for noting the floors are no longer honored, I put in a pr to reflect

@slimkrazy
Copy link
Contributor

@patmmccann - just to add the extra confirmation: This change is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants