Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index Exchange Bid Adapter: BidFloor decimal precision should be 3 or less #6708

Closed
wants to merge 7 commits into from

Conversation

punkiller
Copy link
Contributor

Type of change

  • [ x ] Bugfix

Description of change

The ixBidAdapter should not send bidfloor values with more than 3 decimal precision

Be sure to test the integration with your adserver using the Hello World sample page.

  • contact email of the adapter’s maintainer
  • [x ] official adapter submission

For any changes that affect user-facing APIs or example code documented on http://prebid.org, please provide:

Other information

@patmmccann
Copy link
Collaborator

fwiw your test failures are bc you need to repull master #6706 fixed them

@patmmccann patmmccann changed the title Index Exchange BidFloor decimal precision should be 3 or less Index Exchange Bid Adapter: BidFloor decimal precision should be 3 or less May 5, 2021
@patmmccann
Copy link
Collaborator

Hey @punkiller any reason this is still in draft, looks great and our company for one is eager to see it merged

@punkiller
Copy link
Contributor Author

Hi @patmmccann
Thanks for reviewing, this is something that could also be fixed in our endpoint.
That fix is being tested and if it works out, this merge wont be required.

@bszekely1 bszekely1 requested a review from robertrmartinez May 6, 2021 23:58
@cd0n0van
Copy link

cd0n0van commented May 7, 2021

Hi @patmmccann - as @punkiller mentioned, we were able to resolve this in our endpoint. We'll be closing this PR, but thank you for the quick review!

@punkiller
Copy link
Contributor Author

Thank you @robertrmartinez + @patmmccann , closing this as per @cd0n0van 's guidance .

@punkiller punkiller closed this May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants