Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apacdex Bid Adapter: add support for meta.advertiserDomains, add and update sample adunit, validate dealId field from server response, add support Price Floors Module #6711

Merged
merged 5 commits into from
May 27, 2021
Merged

Apacdex Bid Adapter: add support for meta.advertiserDomains, add and update sample adunit, validate dealId field from server response, add support Price Floors Module #6711

merged 5 commits into from
May 27, 2021

Conversation

thuyhq
Copy link
Contributor

@thuyhq thuyhq commented May 6, 2021 •
edited
Loading

Type of change

  • Bugfix
  • Feature
  • New bidder adapter
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Does this change affect user-facing APIs or examples documented on http://prebid.org?
  • Other

Description of change

@thuyhq thuyhq changed the title add support meta.advertiserDomains, add sample adunit, validate dealId Apacdex Bid Adapter: add support for meta.advertiserDomains, add and update sample adunit, Validate dealId field from server response May 6, 2021
@thuyhq
Copy link
Contributor Author

thuyhq commented May 6, 2021

Hello @ChrisHuie,
Looks like the error from circleCI is not coming from my code. What do I need to do to bypass it?
Thanks very much!

@patmmccann
Copy link
Collaborator

Remerge master, #6706 should help

patmmccann
patmmccann requested changes May 6, 2021
View reviewed changes
modules/apacdexBidAdapter.md Outdated Show resolved Hide resolved
modules/apacdexBidAdapter.md Show resolved Hide resolved
modules/apacdexBidAdapter.md Show resolved Hide resolved
@patmmccann patmmccann self-assigned this May 6, 2021
@thuyhq thuyhq changed the title Apacdex Bid Adapter: add support for meta.advertiserDomains, add and update sample adunit, Validate dealId field from server response Apacdex Bid Adapter: add support for meta.advertiserDomains, add and update sample adunit, validate dealId field from server response, add support Price Floors Module May 7, 2021
@thuyhq thuyhq mentioned this pull request May 7, 2021
Merged
@thuyhq thuyhq requested a review from patmmccann May 8, 2021 17:11
@thuyhq
Copy link
Contributor Author

thuyhq commented May 26, 2021

Hello @patmmccann,
When will my PR be merged?
Is there anything I can do right now?

@patmmccann patmmccann merged commit 7baf4b0 into prebid:master May 27, 2021
patmmccann
patmmccann reviewed May 27, 2021
View reviewed changes
Copy link
Collaborator

@patmmccann patmmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

stsepelin pushed a commit to cointraffic/Prebid.js that referenced this pull request May 28, 2021
@thuyhq @stsepelin
Apacdex Bid Adapter: add support for meta.advertiserDomains, add and …
13e76f9 
…update sample adunit, validate dealId field from server response, add support Price Floors Module (prebid#6711)
prebidtappx pushed a commit to prebidtappx/Prebid.js that referenced this pull request Nov 15, 2021
@thuyhq @agrandes-tappx
Apacdex Bid Adapter: add support for meta.advertiserDomains, add and …
801d208 
…update sample adunit, validate dealId field from server response, add support Price Floors Module (prebid#6711)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann requested changes

Assignees

@patmmccann patmmccann

Labels
maintenance minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thuyhq @patmmccann @ChrisHuie