Adbookpsp Bid Adapter: add new bid adapter #6712
Conversation
ChrisHuie
changed the title
|
Please fix the lint errors in this PR, so that the Circle CI tests will run. Double quotes need to be replaced with single quotes. |
|
I've been able to reproduce the test failures locally, will now try to fix them. I'll mark this PR ready to for review once I'm done to not bother you unnecessarily. |
wgalecki
force-pushed
the
adbookpsp-adapter
branch
3 times, most recently
from
01074e4 to
5ad491a
Compare
wgalecki
force-pushed
the
adbookpsp-adapter
branch
2 times, most recently
from
d6fb751 to
5e14968
Compare
modules/adbookpspBidAdapter.md
Outdated
| params: { | ||
| placementId: 'example-placement-id', | ||
| video: { | ||
| protocols: [2, 3], |
There was a problem hiding this comment.
Please move this to the ad unit
wgalecki
force-pushed
the
adbookpsp-adapter
branch
from
5e14968 to
22460fd
Compare
wgalecki
force-pushed
the
adbookpsp-adapter
branch
from
138208c to
6a8cb8a
Compare
|
I've updated this branch with the latest upstream changes but still some tests are not passing. Do you have any advice? |
|
Tests have passed |
|
|
||
| for (const id of impIds) { | ||
| targetingMap[id] = { | ||
| hb_liid_adbookpsp: values[id].lineItemIds.join(TARGETING_VALUE_SEPARATOR), |
There was a problem hiding this comment.
what is happening here
There was a problem hiding this comment.
In short, we use custom targeting keys to pass additional information to GAM which is then used by our custom creative script to select an ad independently from Prebid.
There was a problem hiding this comment.
Do you want to check said script into integration examples?
There was a problem hiding this comment.
I meant the script rendered by GAM, I'm not sure we're interested in adding an example right now. Is this something you require?
There was a problem hiding this comment.
No, but please add prominent disclosure in your doc repo pull and your .md file that custom gam creatives are required and that this bidder only works in its own gam order and that the prebid universal creative does not work etc. Please be very explicit and redundant.
There was a problem hiding this comment.
I've expanded the note about the adapter requirements in the doc pull request and brought the note to the readme file here.
|
@patmmccann Are there any changes that you're still waiting on or can this be approved? |
* Added adbookpspBidAdapter * Fixed video parameter placement in readme * Simplified video parameters handling * Improved video dimensions handling * Updated readme with note about custom GAM setup
Type of change
Description of change
Added adapter that connects to the AdbookPSP demand sources